[GitHub] [hbase] apurtell commented on pull request #4601: Backport "HBASE-27155 Improvements to low level scanner tracing" to branch-2.5

[GitBox <gi...@apache.org>]

apurtell commented on PR #4601:
URL: https://github.com/apache/hbase/pull/4601#issuecomment-1178214150

   @ndimiduk It does make sense to me that we would decorate the spans with events, and not try to collect metrics as such, as did the original patch. I only did that because aggregate counts at the end of the RPC were sufficient. If I had needed a log of events I would have had to do something more like this. It is nice to have a timeline of events recorded into the span(s) instead, in typical form for otel. 
   
   > How I think you might use this, @apurtell , is to set up tracing with the [Logging Exporter](https://github.com/open-telemetry/opentelemetry-java/tree/v1.15.0/sdk-extensions/autoconfigure#logging-exporter), run your test bench, and then parse the logs to summon them into metrics.
   
   Agreed, converting events into metrics by logging and then counting occurrences over the logs is quite typical here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org