You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "btlqql (via GitHub)" <gi...@apache.org> on 2026/08/13 09:11:02 UTC
[PR] fix(web): localize home placeholder and footer text [rocketmq-dashboard]
btlqql opened a new pull request, #2099:
URL: https://github.com/apache/rocketmq-dashboard/pull/2099
## What is the purpose of the change
Fix #2071.
The home page input placeholder and footer text were hard-coded Chinese while the rest of the page uses i18n.
## Brief changelog
- home/index.tsx: render home.placeholder, home.docs, home.community, home.brand and home.version from translations
- translations.ts: add home.version key
## How was this patch verified
- npx vitest run src/pages/home/__tests__/HomePage.test.tsx (3 passed)
- npx tsc -b clean
- npx eslint . clean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): localize home placeholder and footer text [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #2099:
URL: https://github.com/apache/rocketmq-dashboard/pull/2099#issuecomment-5291348328
Closing per contribution guideline #2107: these are fragmented one-off changes of the same theme (one PR per guard/fix/page). Please group related changes into cohesive pull requests and resubmit — your contributions are welcome in a consolidated shape.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): localize home placeholder and footer text [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2099: fix(web): localize home placeholder and footer text
URL: https://github.com/apache/rocketmq-dashboard/pull/2099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org