[GitHub] [lucene-solr] gautamworah96 commented on pull request #1733: LUCENE-9450 Use BinaryDocValues in the taxonomy writer

[GitBox <gi...@apache.org>]

gautamworah96 commented on pull request #1733:
URL: https://github.com/apache/lucene-solr/pull/1733#issuecomment-672021513


   Changes in this revision (incorporated from feedback on JIRA):
   
   * Added a call to `advanceExact()` before calling `.binaryValue()` and an `assert` to check that the field exists in the index
   * Re-added the `StringField` with the `Field.Store.YES` changed to `Field.Store.NO`.
   
   * I've not added new tests at the moment. Trying to get the existing ones to work first.
   
   From the error log:
   Note that the code is able to successfully execute the `assert found` statement (so the field does exist), and it fails on the next line
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org