You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/03/03 19:15:18 UTC
[GitHub] [trafficcontrol] shamrickus opened a new pull request #6610: Add Test to Catch Missing Permissions
shamrickus opened a new pull request #6610:
URL: https://github.com/apache/trafficcontrol/pull/6610
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
This PR adds a test that checks that at least one user (admin) has all the permissions for the TO API routes. It will catch #6603 and #6609 with a test failure.
Note: until #6609 is fixed, the TO API tests on this PR will fail.
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
- Traffic Ops
## What is the best way to verify this PR?
Run the TO API tests and verify they pass.
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #6610: Add Test to Catch Missing Permissions
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on pull request #6610:
URL: https://github.com/apache/trafficcontrol/pull/6610#issuecomment-1058434420
The definition of the "admin" Role is that it has all Permissions past, present, and future. [The set of Permissions afforded to the "admin" Role isn't even checked by Traffic Ops](https://github.com/apache/trafficcontrol/blob/master/traffic_ops/traffic_ops_golang/auth/authorize.go#L53), so this is testing unintended behavior.
For example: The year is 2024, and I'm adding Foos as a new object to the Traffic Ops API. Foos are not related to any existing objects, and don't affect them in any way. Which users should be granted the `FOO:READ` and `FOO:CREATE` Permissions?
The intended answer is "none" and an "admin"-Role user will be responsible for doling out those new Permissions to whatever Roles need them. That's why we enforce an "admin" Role must exist, and why we treat it specially the way we do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus closed pull request #6610: Add Test to Catch Missing Permissions
Posted by GitBox <gi...@apache.org>.
shamrickus closed pull request #6610:
URL: https://github.com/apache/trafficcontrol/pull/6610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org