You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/08/06 20:21:00 UTC

[jira] [Commented] (IMPALA-7396) Fix crashes when thread_creation_fault_injection is enabled

    [ https://issues.apache.org/jira/browse/IMPALA-7396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570725#comment-16570725 ] 

ASF subversion and git services commented on IMPALA-7396:
---------------------------------------------------------

Commit a0673c058754a323ef88459532f0c19881f3c143 in impala's branch refs/heads/master from [~tarmstrong@cloudera.com]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=a0673c0 ]

IMPALA-7396: unblock testing with --thread_creation_fault_injection

These are minimal fixes to allow testing new patches with the fault
injection.

ClientRequestState: fixing this seems somewhat involved, so disabled the
fault injection for now to unblock further testing.

HdfsScanNode: thread_state_.DecrementNumActive() was called on the error
path before the count had actually been incremented.

Testing:
Ran some of the end-to-end tests for 20-30 minutes and confirmed that
no Impalads crashed.

  start-impala-cluster.py \
    --impalad_args=--thread_creation_fault_injection=true
  impala-py.test tests/query_test/*.py -n2 --verbose

Change-Id: Idc9da645c449a266e3a54d0e35b18a2823019cb7
Reviewed-on: http://gerrit.cloudera.org:8080/11123
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>


> Fix crashes when thread_creation_fault_injection is enabled
> -----------------------------------------------------------
>
>                 Key: IMPALA-7396
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7396
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>             Fix For: Impala 3.1.0
>
>
> {noformat}
> start-impala-cluster.py --impalad_args=--thread_creation_fault_injection=true && impala-py.test tests/query_test/*.py -n4 --verbos
> {noformat}
> {noformat}
> I0803 16:12:43.783825  8111 status.cc:125] Fake thread creation failure (category: query-exec-state, name: wait-thread)
>     @          0x21c9ce7
>     @          0x1756094
>     @          0x22d1039
>     @          0x20bdee8
>     @          0x20b70d1
>     @          0x20cb2ce
>     @          0x34b9dc1
>     @          0x34b9856
>     @          0x34756cf
>     @          0x16edc8e
>     @          0x1db44e5
>     @          0x1da68fe
>     @          0x1da96cb
>     @          0x1da94d3
>     @          0x1da936c
>     @          0x1c40ed7
>     @          0x22d1cbf
>     @          0x22dceb9
>     @          0x22dcd0c
>     @          0x38412ca
>     @     0x7fd40f54b6ba
>     @     0x7fd40f06b41d
> ....
> F0803 16:12:43.804484  8111 coordinator.cc:79] Check failed: exec_state_.Load() != ExecState::EXECUTING (EXECUTING vs. EXECUTING) 
> *** Check failure stack trace: ***
>     @          0x4942896
>     @          0x493923d
>     @          0x493aae2
>     @          0x4938c17
>     @          0x493c1de
>     @          0x36c748b
>     @          0x20c0556
>     @          0x20ad7b4
>     @          0x206baea
>     @          0x16f2a65
>     @          0x20cb9b2
>     @          0x34b9dc1
>     @          0x34b9856
>     @          0x34756cf
>     @          0x16edc8e
> =================================================================
>     @          0x1db44e5
>     @          0x1da68fe
>     @          0x1da96cb
>     @          0x1da94d3
>     @          0x1da936c
>     @          0x1c40ed7
>     @          0x22d1cbf
>     @          0x22dceb9
>     @          0x22dcd0c
>     @          0x38412ca
>     @     0x7fd40f54b6ba
>     @     0x7fd40f06b41d
> Picked up JAVA_TOOL_OPTIONS: -agentlib:jdwp=transport=dt_socket,address=30000,server=y,suspend=n 
> ==7442==ERROR: AddressSanitizer: heap-use-after-free on address 0x60700040ad18 at pc 0x00000170504e bp 0x7fd14bd37720 sp 0x7fd14bd37718
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org