You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/05 17:23:00 UTC
[jira] [Work logged] (BEAM-8450) ParDoLifecycleTest does not allow
for empty bundles
[ https://issues.apache.org/jira/browse/BEAM-8450?focusedWorklogId=338884&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-338884 ]
ASF GitHub Bot logged work on BEAM-8450:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/19 17:22
Start Date: 05/Nov/19 17:22
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #9848: [BEAM-8450] Allow empty bundles in ParDoLifecycleTest
URL: https://github.com/apache/beam/pull/9848#discussion_r342690758
##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoLifecycleTest.java
##########
@@ -291,6 +319,7 @@ public void setup() {
private static class DelayedCallStateTracker {
private CountDownLatch latch;
private AtomicReference<CallState> callState;
+ private Map<CallState, Integer> callStateVisited = new ConcurrentHashMap<>();
Review comment:
Why not a synchronized list? ConcurrentHashMap seems a bit of an overkill.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 338884)
Time Spent: 4h 40m (was: 4.5h)
> ParDoLifecycleTest does not allow for empty bundles
> ---------------------------------------------------
>
> Key: BEAM-8450
> URL: https://issues.apache.org/jira/browse/BEAM-8450
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: Major
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> ParDoLifecycleTest should allow empty bundles produced by runner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)