You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Igor Bondarenko <je...@gmail.com> on 2015/08/18 10:56:58 UTC

[allura:tickets] #7538 If diff is empty, it shouldn't show "empty file" [ss7532]



---

** [tickets:#7538] If diff is empty, it shouldn't show "empty file" [ss7532]**

**Status:** in-progress
**Milestone:** unreleased
**Labels:** p3 support 42cc bitesize 
**Created:** Sat Jul 05, 2014 03:33 PM UTC by Chris Tsai
**Last Updated:** Sat Mar 14, 2015 12:01 PM UTC
**Owner:** Igor Bondarenko


[forge:site-support:#7352]

>In this revision
https://sourceforge.net/p/kaldi/code/3889/
there were some property changes on files, but this is displayed by your site in a misleading way. It says
changed /trunk/egs/wsj/s5/steps/nnet2/dump_bottleneck_features.sh
changed /trunk/egs/wsj/s5/steps/nnet2/train_tanh_bottleneck.sh
and then later on, it says

>/trunk/egs/wsj/s5/steps/nnet2/dump_bottleneck_features.sh Diff Switch to side-by-side view
Empty file
/trunk/egs/wsj/s5/steps/nnet2/train_tanh_bottleneck.sh Diff Switch to side-by-side view
Empty file

>This looks like the user deleted the file, but what really happened is that they changed the svn:executable property to have a value ('').

Seems to me that the problem is the text used when the diff returns empty. Perhaps changing to "File contents unchanged" would work.


---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] Ticket 7538 discussion

Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: in-progress --> review



---

** [tickets:#7538] If diff is empty, it shouldn't show "empty file" [ss7532]**

**Status:** review
**Milestone:** unreleased
**Labels:** p3 support 42cc bitesize 
**Created:** Sat Jul 05, 2014 03:33 PM UTC by Chris Tsai
**Last Updated:** Sat Aug 29, 2015 05:16 PM UTC
**Owner:** Igor Bondarenko


[forge:site-support:#7352]

>In this revision
https://sourceforge.net/p/kaldi/code/3889/
there were some property changes on files, but this is displayed by your site in a misleading way. It says
changed /trunk/egs/wsj/s5/steps/nnet2/dump_bottleneck_features.sh
changed /trunk/egs/wsj/s5/steps/nnet2/train_tanh_bottleneck.sh
and then later on, it says

>/trunk/egs/wsj/s5/steps/nnet2/dump_bottleneck_features.sh Diff Switch to side-by-side view
Empty file
/trunk/egs/wsj/s5/steps/nnet2/train_tanh_bottleneck.sh Diff Switch to side-by-side view
Empty file

>This looks like the user deleted the file, but what really happened is that they changed the svn:executable property to have a value ('').

Seems to me that the problem is the text used when the diff returns empty. Perhaps changing to "File contents unchanged" would work.


---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] Ticket 7538 discussion

Posted by LXj <go...@gmail.com>.
https://forge-allura.apache.org/p/allura/git/merge-requests/35/


---

** [tickets:#7538] If diff is empty, it shouldn't show "empty file" [ss7532]**

**Status:** in-progress
**Milestone:** unreleased
**Labels:** p3 support 42cc bitesize 
**Created:** Sat Jul 05, 2014 03:33 PM UTC by Chris Tsai
**Last Updated:** Tue Aug 18, 2015 08:56 AM UTC
**Owner:** Igor Bondarenko


[forge:site-support:#7352]

>In this revision
https://sourceforge.net/p/kaldi/code/3889/
there were some property changes on files, but this is displayed by your site in a misleading way. It says
changed /trunk/egs/wsj/s5/steps/nnet2/dump_bottleneck_features.sh
changed /trunk/egs/wsj/s5/steps/nnet2/train_tanh_bottleneck.sh
and then later on, it says

>/trunk/egs/wsj/s5/steps/nnet2/dump_bottleneck_features.sh Diff Switch to side-by-side view
Empty file
/trunk/egs/wsj/s5/steps/nnet2/train_tanh_bottleneck.sh Diff Switch to side-by-side view
Empty file

>This looks like the user deleted the file, but what really happened is that they changed the svn:executable property to have a value ('').

Seems to me that the problem is the text used when the diff returns empty. Perhaps changing to "File contents unchanged" would work.


---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] Ticket 7538 discussion

Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: review --> closed
- **Reviewer**: Dave Brondsema



---

** [tickets:#7538] If diff is empty, it shouldn't show "empty file" [ss7532]**

**Status:** closed
**Milestone:** unreleased
**Labels:** p3 support 42cc bitesize 
**Created:** Sat Jul 05, 2014 03:33 PM UTC by Chris Tsai
**Last Updated:** Mon Aug 31, 2015 01:57 PM UTC
**Owner:** Igor Bondarenko


[forge:site-support:#7352]

>In this revision
https://sourceforge.net/p/kaldi/code/3889/
there were some property changes on files, but this is displayed by your site in a misleading way. It says
changed /trunk/egs/wsj/s5/steps/nnet2/dump_bottleneck_features.sh
changed /trunk/egs/wsj/s5/steps/nnet2/train_tanh_bottleneck.sh
and then later on, it says

>/trunk/egs/wsj/s5/steps/nnet2/dump_bottleneck_features.sh Diff Switch to side-by-side view
Empty file
/trunk/egs/wsj/s5/steps/nnet2/train_tanh_bottleneck.sh Diff Switch to side-by-side view
Empty file

>This looks like the user deleted the file, but what really happened is that they changed the svn:executable property to have a value ('').

Seems to me that the problem is the text used when the diff returns empty. Perhaps changing to "File contents unchanged" would work.


---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.