You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Javier Puerto (JIRA)" <ji...@apache.org> on 2012/05/20 15:10:42 UTC

[jira] [Created] (COCOON3-100) Make IncludeTransformer cacheable.

Javier Puerto created COCOON3-100:
-------------------------------------

             Summary: Make IncludeTransformer cacheable.
                 Key: COCOON3-100
                 URL: https://issues.apache.org/jira/browse/COCOON3-100
             Project: Cocoon 3
          Issue Type: Improvement
          Components: cocoon-pipeline, cocoon-sax
    Affects Versions: 3.0.0-beta-1
            Reporter: Javier Puerto


We need to implements CachingPipelineComponent. Like older Cocoon versions, we can ask for the SourceValidity of the implicated resources.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (COCOON3-100) Make IncludeTransformer cacheable.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COCOON3-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405895#comment-13405895 ] 

Hudson commented on COCOON3-100:
--------------------------------

Integrated in Cocoon-trunk #205 (See [https://builds.apache.org/job/Cocoon-trunk/205/])
    [COCOON3-102] Applying (and reworking a bit) the proposed patch for COCOON3-100, replacing URLCacheKey with URLConnectionUtils.getLastModified() (Revision 1356609)

     Result = SUCCESS
ilgrosso : http://svn.apache.org/viewvc/?view=rev&rev=1356609
Files : 
* /cocoon/cocoon3/trunk/cocoon-optional/src/main/java/org/apache/cocoon/optional/pipeline/components/sax/jaxb/JAXBGenerator.java
* /cocoon/cocoon3/trunk/cocoon-optional/src/main/java/org/apache/cocoon/optional/pipeline/components/sax/jaxb/ObjectCacheKey.java
* /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/CachedCacheKey.java
* /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/CachedCacheValue.java
* /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/CompoundCacheKey.java
* /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/ObjectCacheKey.java
* /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/TimestampCacheKey.java
* /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/caching/URLListCacheKey.java
* /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/util/URLConnectionUtils.java
* /cocoon/cocoon3/trunk/cocoon-sample/src/main/resources/COB-INF/sitemap.xmap
* /cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/component/SchemaProcessorTransformer.java
* /cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/component/XIncludeTransformer.java
* /cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/component/XMLGenerator.java
* /cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/component/XSLTTransformer.java
* /cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/util/URLUtils.java
* /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/component/FileReaderComponent.java
* /cocoon/cocoon3/trunk/cocoon-stringtemplate/src/main/java/org/apache/cocoon/stringtemplate/StringTemplateGenerator.java
* /cocoon/cocoon3/trunk/cocoon-stringtemplate/src/main/java/org/apache/cocoon/stringtemplate/StringTemplateReader.java

                
> Make IncludeTransformer cacheable.
> ----------------------------------
>
>                 Key: COCOON3-100
>                 URL: https://issues.apache.org/jira/browse/COCOON3-100
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline, cocoon-sax
>    Affects Versions: 3.0.0-beta-1
>            Reporter: Javier Puerto
>         Attachments: COCOON3-100.diff, ResponseHeaderCollector.diff
>
>
> We need to implements CachingPipelineComponent. Like older Cocoon versions, we can ask for the SourceValidity of the implicated resources.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (COCOON3-100) Make IncludeTransformer cacheable.

Posted by "Javier Puerto (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COCOON3-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279749#comment-13279749 ] 

Javier Puerto commented on COCOON3-100:
---------------------------------------

I've moved the ObjectCacheKey from cocoon-optional to cocoon-pipeline, please do a svn move instead.

The implementation could be better in performance because we need to open connections to the resources to get the "Last-Modified" header value but it's fine for "file://" resources. Maybe an internal expires value?

                
> Make IncludeTransformer cacheable.
> ----------------------------------
>
>                 Key: COCOON3-100
>                 URL: https://issues.apache.org/jira/browse/COCOON3-100
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline, cocoon-sax
>    Affects Versions: 3.0.0-beta-1
>            Reporter: Javier Puerto
>         Attachments: COCOON3-100.diff
>
>
> We need to implements CachingPipelineComponent. Like older Cocoon versions, we can ask for the SourceValidity of the implicated resources.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (COCOON3-100) Make IncludeTransformer cacheable.

Posted by "Javier Puerto (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON3-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Javier Puerto updated COCOON3-100:
----------------------------------

    Attachment: COCOON3-100.diff

Add CachedCacheKey class and URLCacheKey.
Move ObjectCacheKey from cocoon-optional.
Add caching support to IncludeTransformer.
Modify IncludeTransformer pipeline in cocoon-sample
                
> Make IncludeTransformer cacheable.
> ----------------------------------
>
>                 Key: COCOON3-100
>                 URL: https://issues.apache.org/jira/browse/COCOON3-100
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline, cocoon-sax
>    Affects Versions: 3.0.0-beta-1
>            Reporter: Javier Puerto
>         Attachments: COCOON3-100.diff
>
>
> We need to implements CachingPipelineComponent. Like older Cocoon versions, we can ask for the SourceValidity of the implicated resources.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (COCOON3-100) Make IncludeTransformer cacheable.

Posted by "Javier Puerto (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON3-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Javier Puerto updated COCOON3-100:
----------------------------------

    Attachment: ResponseHeaderCollector.diff

Working on this patch I've unified how ResponseHeaderCollector retrieves the Long values.
                
> Make IncludeTransformer cacheable.
> ----------------------------------
>
>                 Key: COCOON3-100
>                 URL: https://issues.apache.org/jira/browse/COCOON3-100
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline, cocoon-sax
>    Affects Versions: 3.0.0-beta-1
>            Reporter: Javier Puerto
>         Attachments: COCOON3-100.diff, ResponseHeaderCollector.diff
>
>
> We need to implements CachingPipelineComponent. Like older Cocoon versions, we can ask for the SourceValidity of the implicated resources.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira