You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2026/03/23 02:34:28 UTC

[PR] [env](compiler)Optimize the compilation time of aggregate_function_orthogonal_bitmap.cpp [doris]

Mryange opened a new pull request, #61606:
URL: https://github.com/apache/doris/pull/61606

   ### What problem does this PR solve?
   
   Optimize the compilation time of `aggregate_function_orthogonal_bitmap.cpp` by reducing template instantiation bloat and improving build parallelism.
   
   ### Changes
   
   **1. Split single translation unit into multiple files**
   
   The original `aggregate_function_orthogonal_bitmap.cpp` instantiated all 6 aggregate functions (~36 template instances) in a single file, forcing serial compilation. Now split into:
   
   - `aggregate_function_orthogonal_bitmap.cpp` — forward declarations + registration only (compiles fast)
   - `aggregate_function_orth_bitmap_intersect.cpp`
   - `aggregate_function_orth_bitmap_intersect_count.cpp`
   - `aggregate_function_orth_bitmap_union_count.cpp`
   - `aggregate_function_orth_intersect_count.cpp`
   - `aggregate_function_orth_bitmap_expr_cal.cpp`
   - `aggregate_function_orth_bitmap_expr_cal_count.cpp`
   
   **2. Remove unnecessary `PrimitiveType` template parameter from `OrthBitmapUnionCountData`**
   
   `OrthBitmapUnionCountData<T>` never uses `T` — it only operates on `ColumnBitmap` directly. Removed the template parameter, reducing 6 useless instantiations to 1.
   
   **3. Eliminate type dispatch for `ExprCal` / `ExprCalCount`**
   
   FE guarantees these functions receive exactly 3 parameters with VARCHAR filter columns. Replaced the generic 6-type dispatch with direct `TYPE_STRING` instantiation, reducing 12 instantiations to 2.
   
   **4. Use precise expression tags matching FE definitions**
   
   Added `ExprTag` template parameter to `AggFunctionOrthBitmapFunc` (default: `VarargsExpression`):
   
   | Function | FE Arity | Old BE Tag | New BE Tag |
   |----------|----------|------------|------------|
   | `orthogonal_bitmap_union_count` | `UnaryExpression` (1 arg) | `VarargsExpression` | `UnaryExpression` |
   | `orthogonal_bitmap_expr_calculate` | Fixed 3 args | `VarargsExpression` | `MultiExpression` |
   | `orthogonal_bitmap_expr_calculate_count` | Fixed 3 args | `VarargsExpression` | `MultiExpression` |
   | Others (intersect/intersect_count) | Varargs (≥3) | `VarargsExpression` | `VarargsExpression` (unchanged) |
   
   **5. Add `inline` to template specializations in `bitmap_intersect.h`**
   
   The `Helper::write_to` / `serialize_size` / `read_from` template specializations in the header lacked `inline`, causing duplicate symbol linker errors after splitting into multiple translation units.
   
   ### Summary
   
   | Metric | Before | After |
   |--------|--------|-------|
   | Translation units | 1 (serial) | 7 (parallel) |
   | Template instantiations | ~36 | ~21 (~42% reduction) |
   | `ExprCal`/`ExprCalCount` instantiations | 12 | 2 |
   | `OrthBitmapUnionCountData` instantiations | 6 | 1 |
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compiler)Optimize the compilation time of aggregate_function_orthogonal_bitmap.cpp [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61606:
URL: https://github.com/apache/doris/pull/61606#issuecomment-4152809450

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compiler)Optimize the compilation time of aggregate_function_orthogonal_bitmap.cpp [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #61606:
URL: https://github.com/apache/doris/pull/61606#issuecomment-4107604362

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compiler)Optimize the compilation time of aggregate_function_orthogonal_bitmap.cpp [doris]

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #61606:
URL: https://github.com/apache/doris/pull/61606#issuecomment-4152734289

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compiler)Optimize the compilation time of aggregate_function_orthogonal_bitmap.cpp [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #61606:
URL: https://github.com/apache/doris/pull/61606#issuecomment-4110794694

   run beut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compiler)Optimize the compilation time of aggregate_function_orthogonal_bitmap.cpp [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61606:
URL: https://github.com/apache/doris/pull/61606#issuecomment-4107753667

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 168490 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit cf2cc2681eea34d8575cb94e20631477cdd7a765, data reload: false
   
   query5	4328	630	491	491
   query6	337	234	216	216
   query7	4211	472	270	270
   query8	350	256	250	250
   query9	8740	2772	2733	2733
   query10	518	419	355	355
   query11	6949	5107	4844	4844
   query12	185	141	133	133
   query13	1279	473	358	358
   query14	5727	3754	3536	3536
   query14_1	2891	2834	2860	2834
   query15	213	201	176	176
   query16	983	494	462	462
   query17	928	729	624	624
   query18	2460	456	354	354
   query19	247	200	174	174
   query20	135	129	126	126
   query21	207	132	110	110
   query22	13251	14046	14580	14046
   query23	16176	15689	15586	15586
   query23_1	16079	15623	15298	15298
   query24	7269	1609	1235	1235
   query24_1	1227	1231	1219	1219
   query25	544	489	392	392
   query26	1232	259	152	152
   query27	2774	487	298	298
   query28	4492	1847	1834	1834
   query29	840	578	484	484
   query30	300	228	189	189
   query31	1007	935	863	863
   query32	79	73	69	69
   query33	519	340	309	309
   query34	882	880	543	543
   query35	648	687	602	602
   query36	1087	1162	986	986
   query37	127	98	85	85
   query38	2958	2919	2877	2877
   query39	853	847	799	799
   query39_1	802	807	784	784
   query40	240	155	139	139
   query41	68	65	63	63
   query42	258	262	257	257
   query43	247	253	222	222
   query44	
   query45	206	194	186	186
   query46	882	1010	619	619
   query47	2112	2107	2064	2064
   query48	310	326	234	234
   query49	651	474	403	403
   query50	699	289	225	225
   query51	4062	4054	4055	4054
   query52	266	269	268	268
   query53	308	340	284	284
   query54	351	299	293	293
   query55	90	91	86	86
   query56	328	333	368	333
   query57	1944	1816	1561	1561
   query58	287	278	271	271
   query59	2819	2947	2776	2776
   query60	351	341	324	324
   query61	147	153	157	153
   query62	632	588	531	531
   query63	310	283	277	277
   query64	5075	1292	1010	1010
   query65	
   query66	1457	463	362	362
   query67	24269	24352	24244	24244
   query68	
   query69	406	309	296	296
   query70	973	956	941	941
   query71	345	310	298	298
   query72	2903	2677	2451	2451
   query73	532	554	333	333
   query74	9698	9627	9395	9395
   query75	2865	2768	2463	2463
   query76	2290	1044	670	670
   query77	372	405	320	320
   query78	10932	11019	10483	10483
   query79	2830	757	597	597
   query80	1785	619	583	583
   query81	550	262	223	223
   query82	998	152	118	118
   query83	333	261	246	246
   query84	299	123	101	101
   query85	906	506	449	449
   query86	407	335	298	298
   query87	3137	3166	3042	3042
   query88	3597	2697	2701	2697
   query89	428	373	350	350
   query90	2015	176	176	176
   query91	175	159	139	139
   query92	80	81	70	70
   query93	1188	832	499	499
   query94	638	331	276	276
   query95	589	349	380	349
   query96	651	528	230	230
   query97	2459	2521	2421	2421
   query98	243	236	233	233
   query99	1023	996	913	913
   Total cold run time: 252255 ms
   Total hot run time: 168490 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compiler)Optimize the compilation time of aggregate_function_orthogonal_bitmap.cpp [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #61606:
URL: https://github.com/apache/doris/pull/61606#issuecomment-4107632491

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compiler)Optimize the compilation time of aggregate_function_orthogonal_bitmap.cpp [doris]

Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #61606:
URL: https://github.com/apache/doris/pull/61606


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compiler)Optimize the compilation time of aggregate_function_orthogonal_bitmap.cpp [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61606:
URL: https://github.com/apache/doris/pull/61606#issuecomment-4111413092

   # BE UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/cf2cc2681eea34d8575cb94e20631477cdd7a765_cf2cc2681eea34d8575cb94e20631477cdd7a765/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/cf2cc2681eea34d8575cb94e20631477cdd7a765_cf2cc2681eea34d8575cb94e20631477cdd7a765/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.79% (19850/37603) |
   | Line Coverage     | 36.27% (185281/510768) |
   | Region Coverage   | 32.56% (143630/441184) |
   | Branch Coverage   | 33.74% (62848/186282) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compiler)Optimize the compilation time of aggregate_function_orthogonal_bitmap.cpp [doris]

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #61606:
URL: https://github.com/apache/doris/pull/61606#issuecomment-4122687488

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compiler)Optimize the compilation time of aggregate_function_orthogonal_bitmap.cpp [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61606:
URL: https://github.com/apache/doris/pull/61606#issuecomment-4107727149

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 27139 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit cf2cc2681eea34d8575cb94e20631477cdd7a765, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17584	4416	5193	4416
   q2	q3	10644	791	537	537
   q4	4682	370	254	254
   q5	7566	1247	1005	1005
   q6	173	173	143	143
   q7	789	857	685	685
   q8	9312	1491	1396	1396
   q9	4905	4746	4717	4717
   q10	6293	1910	1639	1639
   q11	452	263	245	245
   q12	746	587	468	468
   q13	18041	2901	2196	2196
   q14	233	233	214	214
   q15	q16	749	725	661	661
   q17	732	875	449	449
   q18	6052	5342	5230	5230
   q19	1114	985	630	630
   q20	548	494	371	371
   q21	4440	1851	1576	1576
   q22	457	386	307	307
   Total cold run time: 95512 ms
   Total hot run time: 27139 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4713	4570	4584	4570
   q2	q3	3938	4403	3817	3817
   q4	871	1240	788	788
   q5	4175	4450	4407	4407
   q6	182	176	145	145
   q7	1777	1686	1523	1523
   q8	2638	2751	2613	2613
   q9	7600	7385	7288	7288
   q10	3749	3994	3578	3578
   q11	530	446	422	422
   q12	490	596	460	460
   q13	2783	3311	2322	2322
   q14	298	291	278	278
   q15	q16	727	778	740	740
   q17	1219	1388	1353	1353
   q18	7256	6713	6917	6713
   q19	938	939	926	926
   q20	2069	2134	2278	2134
   q21	4059	3585	3402	3402
   q22	463	424	389	389
   Total cold run time: 50475 ms
   Total hot run time: 47868 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compiler)Optimize the compilation time of aggregate_function_orthogonal_bitmap.cpp [doris]

Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #61606:
URL: https://github.com/apache/doris/pull/61606#issuecomment-4107604019

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compiler)Optimize the compilation time of aggregate_function_orthogonal_bitmap.cpp [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61606:
URL: https://github.com/apache/doris/pull/61606#issuecomment-4111459772

   # BE Regression && UT Coverage Report
   Increment line coverage `100% (0/0)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/61606_cf2cc2681eea34d8575cb94e20631477cdd7a765_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/61606_cf2cc2681eea34d8575cb94e20631477cdd7a765_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 73.34% (26993/36805) |
   | Line Coverage     | 56.73% (288746/508979) |
   | Region Coverage   | 54.13% (240922/445098) |
   | Branch Coverage   | 55.82% (104232/186715) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compiler)Optimize the compilation time of aggregate_function_orthogonal_bitmap.cpp [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61606:
URL: https://github.com/apache/doris/pull/61606#issuecomment-4152772241

   ## Code Review Summary
   
   **Goal:** Optimize compilation time of `aggregate_function_orthogonal_bitmap.cpp` by splitting into multiple translation units and reducing template instantiation bloat. This is a **pure refactoring/build optimization** with no intended behavioral changes.
   
   ### Critical Checkpoint Conclusions
   
   1. **Does the code accomplish its goal?** Yes. The single TU is split into 7 files enabling parallel compilation. Template instantiations are reduced from ~36 to ~21. Existing regression tests (`test_orthogonal_bitmap_expr_calculate.groovy`, `test_bitmap_function.groovy`, etc.) cover functional correctness.
   
   2. **Is the modification minimal, clear, and focused?** Yes. Changes are well-scoped to the orthogonal bitmap aggregate functions with no unrelated changes.
   
   3. **Concurrency?** Not applicable — no concurrent data access introduced.
   
   4. **Lifecycle management?** Not applicable — no new static variables or lifecycle changes.
   
   5. **Configuration items?** None added.
   
   6. **Incompatible changes / rolling upgrades?** No incompatible changes. The `ExprTag` changes (`VarargsExpression` → `UnaryExpression`/`MultiExpression`) only affect which nullable wrapper creation path is selected at compile time, and the runtime behavior is equivalent:
      - `orthogonal_bitmap_union_count`: FE guarantees 1 arg. Old code went through `create_varargs` → runtime branch selected `NullableUnary`. New code goes through `create_unary_arguments` → same `NullableUnary`.
      - `expr_calculate`/`expr_calculate_count`: FE guarantees 3 args. Old code went through `create_varargs` → runtime branch selected `NullableVariadic`. New code goes through `create_multi_arguments` → same `NullableVariadic`.
   
   7. **Parallel code paths?** The `creator_with_type_list_base::create<AggFunctionOrthBitmapFunc, Impl>` in `_impl.h` uses `CurryData` which maps `AggFunctionOrthBitmapFunc` as `template <typename>`, relying on the default `ExprTag = VarargsExpression`. This is correct for the varargs functions (intersect, intersect_count) that go through this path.
   
   8. **`OrthBitmapUnionCountData` de-templatization:** Correct. The original `template <PrimitiveType T>` parameter was never used — the struct only operates on `ColumnBitmap` and `BitmapValue` directly.
   
   9. **`inline` additions in `bitmap_intersect.h`:** Correct and necessary. Explicit template specializations defined in a header need `inline` to avoid ODR violations when the header is included from multiple TUs.
   
   10. **Test coverage?** Existing regression tests cover these functions. No behavioral change, so no new tests are needed. The PR checklist should mark "Previous test can cover this change."
   
   11. **Performance?** No runtime performance impact — this is a compile-time optimization only.
   
   12. **Other issues?** Minor: `aggregate_function_orthogonal_bitmap_impl.h` does not include `compile_check_begin.h`/`compile_check_end.h`, unlike every other header in the `be/src/exprs/aggregate/` directory. Not a correctness issue but a convention gap worth noting.
   
   ### Verdict
   No blocking issues found. The refactoring is correct, well-structured, and preserves behavioral equivalence.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compiler)Optimize the compilation time of aggregate_function_orthogonal_bitmap.cpp [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61606:
URL: https://github.com/apache/doris/pull/61606#issuecomment-4152809680

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org