[GitHub] [pulsar] rdhabalia commented on a change in pull request #14382: [pulsar-broker] support client configurable message chunk size

[GitBox <gi...@apache.org>]

rdhabalia commented on a change in pull request #14382:
URL: https://github.com/apache/pulsar/pull/14382#discussion_r823038542



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##########
@@ -1525,6 +1530,7 @@ public int messagesCount() {
     @Override
     public void connectionOpened(final ClientCnx cnx) {
         previousExceptions.clear();
+        chunkMaxMessageSize = Math.min(chunkMaxMessageSize, ClientCnx.getMaxMessageSize());

Review comment:
       no, the concern is not changing chunk on new connection but pulsar-client first sets `ClientCnx.getMaxMessageSize()` on first connection opened when it receives an update from the broker. anyway, max-size is not something broker specific but it's bk specific so, no need to handle such a scenario where it can change broker to broker.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org