You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by rs...@apache.org on 2019/04/15 11:42:47 UTC
[kafka] branch trunk updated: KAFKA-8232;
Test topic delete completion rather than intermediate state (#6581)
This is an automated email from the ASF dual-hosted git repository.
rsivaram pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 51a67d5 KAFKA-8232; Test topic delete completion rather than intermediate state (#6581)
51a67d5 is described below
commit 51a67d52cbd9aee0b0dacd33cca5f39322aae4ef
Author: Rajini Sivaram <ra...@googlemail.com>
AuthorDate: Mon Apr 15 12:42:23 2019 +0100
KAFKA-8232; Test topic delete completion rather than intermediate state (#6581)
Reviewers: Manikumar Reddy <ma...@gmail.com>
---
.../test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala b/core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
index d1eac2d..bc0eadf 100644
--- a/core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
+++ b/core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
@@ -468,7 +468,7 @@ class TopicCommandWithAdminClientTest extends KafkaServerTestHarness with Loggin
val deletePath = DeleteTopicsTopicZNode.path(testTopicName)
assertFalse("Delete path for topic shouldn't exist before deletion.", zkClient.pathExists(deletePath))
topicService.deleteTopic(deleteOpts)
- assertTrue("Delete path for topic should exist after deletion.", zkClient.pathExists(deletePath))
+ TestUtils.verifyTopicDeletion(zkClient, testTopicName, 1, servers)
}
@Test
@@ -486,7 +486,7 @@ class TopicCommandWithAdminClientTest extends KafkaServerTestHarness with Loggin
val deleteOffsetTopicPath = DeleteTopicsTopicZNode.path(Topic.GROUP_METADATA_TOPIC_NAME)
assertFalse("Delete path for topic shouldn't exist before deletion.", zkClient.pathExists(deleteOffsetTopicPath))
topicService.deleteTopic(deleteOffsetTopicOpts)
- assertTrue("Delete path for topic should exist after deletion.", zkClient.pathExists(deleteOffsetTopicPath))
+ TestUtils.verifyTopicDeletion(zkClient, Topic.GROUP_METADATA_TOPIC_NAME, 1, servers)
}
@Test