You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (Created) (JIRA)" <ji...@apache.org> on 2012/02/14 05:14:59 UTC

[jira] [Created] (HADOOP-8070) Add standalone benchmark of protobuf IPC

Add standalone benchmark of protobuf IPC
----------------------------------------

                 Key: HADOOP-8070
                 URL: https://issues.apache.org/jira/browse/HADOOP-8070
             Project: Hadoop Common
          Issue Type: Improvement
          Components: benchmarks, ipc
    Affects Versions: 0.24.0
            Reporter: Todd Lipcon
            Assignee: Todd Lipcon
             Fix For: 0.24.0


To be more comfortable with the switch to protobuf IPC, I'd like to contribute a standalone benchmark which can start any number of client threads and server threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8070) Add standalone benchmark of protobuf IPC

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207971#comment-13207971 ] 

Hudson commented on HADOOP-8070:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #1726 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1726/])
    HADOOP-8070. Add a standalone benchmark for RPC call performance. Contributed by Todd Lipcon. (Revision 1244185)

     Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244185
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/RPCCallBenchmark.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCallBenchmark.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MultithreadedTestUtil.java

                
> Add standalone benchmark of protobuf IPC
> ----------------------------------------
>
>                 Key: HADOOP-8070
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8070
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: benchmarks, ipc
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.24.0
>
>         Attachments: hadoop-8070.txt, hadoop-8070.txt, hadoop-8070.txt
>
>
> To be more comfortable with the switch to protobuf IPC, I'd like to contribute a standalone benchmark which can start any number of client threads and server threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8070) Add standalone benchmark of protobuf IPC

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208424#comment-13208424 ] 

Hudson commented on HADOOP-8070:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #956 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/956/])
    HADOOP-8070. Add a standalone benchmark for RPC call performance. Contributed by Todd Lipcon. (Revision 1244185)

     Result = FAILURE
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244185
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/RPCCallBenchmark.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCallBenchmark.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MultithreadedTestUtil.java

                
> Add standalone benchmark of protobuf IPC
> ----------------------------------------
>
>                 Key: HADOOP-8070
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8070
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: benchmarks, ipc
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.24.0
>
>         Attachments: hadoop-8070.txt, hadoop-8070.txt, hadoop-8070.txt
>
>
> To be more comfortable with the switch to protobuf IPC, I'd like to contribute a standalone benchmark which can start any number of client threads and server threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8070) Add standalone benchmark of protobuf IPC

Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-8070:
-------------------------------------------

    Fix Version/s: 0.23.3

I have merged this to 0.23.
                
> Add standalone benchmark of protobuf IPC
> ----------------------------------------
>
>                 Key: HADOOP-8070
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8070
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: benchmarks, ipc
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.24.0, 0.23.3
>
>         Attachments: hadoop-8070.txt, hadoop-8070.txt, hadoop-8070.txt
>
>
> To be more comfortable with the switch to protobuf IPC, I'd like to contribute a standalone benchmark which can start any number of client threads and server threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8070) Add standalone benchmark of protobuf IPC

Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-8070:
--------------------------------

    Attachment: hadoop-8070.txt

Good catch. I actually should be setting the rpc engine above either of the client/server code paths, so that the server-only or client-only cases work. I'll commit this momentarily since it's a trivial change and only in the new benchmark code
                
> Add standalone benchmark of protobuf IPC
> ----------------------------------------
>
>                 Key: HADOOP-8070
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8070
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: benchmarks, ipc
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.24.0
>
>         Attachments: hadoop-8070.txt, hadoop-8070.txt, hadoop-8070.txt
>
>
> To be more comfortable with the switch to protobuf IPC, I'd like to contribute a standalone benchmark which can start any number of client threads and server threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8070) Add standalone benchmark of protobuf IPC

Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207529#comment-13207529 ] 

Suresh Srinivas commented on HADOOP-8070:
-----------------------------------------

Nice job, Todd.
                
> Add standalone benchmark of protobuf IPC
> ----------------------------------------
>
>                 Key: HADOOP-8070
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8070
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: benchmarks, ipc
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.24.0
>
>         Attachments: hadoop-8070.txt, hadoop-8070.txt
>
>
> To be more comfortable with the switch to protobuf IPC, I'd like to contribute a standalone benchmark which can start any number of client threads and server threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8070) Add standalone benchmark of protobuf IPC

Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-8070:
--------------------------------

      Resolution: Fixed
    Hadoop Flags: Reviewed
          Status: Resolved  (was: Patch Available)

Committed to trunk. We can merge this back to 0.23.x when the protobuf stuff is merged there later.
                
> Add standalone benchmark of protobuf IPC
> ----------------------------------------
>
>                 Key: HADOOP-8070
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8070
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: benchmarks, ipc
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.24.0
>
>         Attachments: hadoop-8070.txt, hadoop-8070.txt, hadoop-8070.txt
>
>
> To be more comfortable with the switch to protobuf IPC, I'd like to contribute a standalone benchmark which can start any number of client threads and server threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8070) Add standalone benchmark of protobuf IPC

Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-8070:
--------------------------------

    Status: Patch Available  (was: Open)
    
> Add standalone benchmark of protobuf IPC
> ----------------------------------------
>
>                 Key: HADOOP-8070
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8070
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: benchmarks, ipc
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.24.0
>
>         Attachments: hadoop-8070.txt
>
>
> To be more comfortable with the switch to protobuf IPC, I'd like to contribute a standalone benchmark which can start any number of client threads and server threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8070) Add standalone benchmark of protobuf IPC

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208474#comment-13208474 ] 

Hudson commented on HADOOP-8070:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #991 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/991/])
    HADOOP-8070. Add a standalone benchmark for RPC call performance. Contributed by Todd Lipcon. (Revision 1244185)

     Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244185
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/RPCCallBenchmark.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCallBenchmark.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MultithreadedTestUtil.java

                
> Add standalone benchmark of protobuf IPC
> ----------------------------------------
>
>                 Key: HADOOP-8070
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8070
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: benchmarks, ipc
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.24.0
>
>         Attachments: hadoop-8070.txt, hadoop-8070.txt, hadoop-8070.txt
>
>
> To be more comfortable with the switch to protobuf IPC, I'd like to contribute a standalone benchmark which can start any number of client threads and server threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8070) Add standalone benchmark of protobuf IPC

Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207568#comment-13207568 ] 

Eli Collins commented on HADOOP-8070:
-------------------------------------

+1 looks great. 

Nit, remove the commented out code below "Set RPC engine to protobuf RPC engine" since you set this via the command line option.
                
> Add standalone benchmark of protobuf IPC
> ----------------------------------------
>
>                 Key: HADOOP-8070
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8070
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: benchmarks, ipc
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.24.0
>
>         Attachments: hadoop-8070.txt, hadoop-8070.txt
>
>
> To be more comfortable with the switch to protobuf IPC, I'd like to contribute a standalone benchmark which can start any number of client threads and server threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8070) Add standalone benchmark of protobuf IPC

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207525#comment-13207525 ] 

Hadoop QA commented on HADOOP-8070:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12514448/hadoop-8070.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 7 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/592//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/592//console

This message is automatically generated.
                
> Add standalone benchmark of protobuf IPC
> ----------------------------------------
>
>                 Key: HADOOP-8070
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8070
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: benchmarks, ipc
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.24.0
>
>         Attachments: hadoop-8070.txt, hadoop-8070.txt
>
>
> To be more comfortable with the switch to protobuf IPC, I'd like to contribute a standalone benchmark which can start any number of client threads and server threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8070) Add standalone benchmark of protobuf IPC

Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-8070:
--------------------------------

    Attachment: hadoop-8070.txt

Attached is the benchmark. Sample invocation:

/usr/lib/jvm/java-6-sun/bin/java -cp /home/todd/git/hadoop-common/hadoop-dist/target/hadoop-0.24.0-SNAPSHOT/share/hadoop/common/lib/*:target/classes:target/test-classes org.apache.hadoop.ipc.PBRPCBenchmark -r 4 -c 30 -s 30 -t 30 -m 1024

and usage output:
{code}
Protobuf IPC benchmark.

usage: java ... PBRPCBenchmark [options]

Supported options:
 -?,--help                            show this screen
 -c,--clientThreads <numthreads>      number of client threads to run (or 0 to not run client)
 -h,--host <addr>                     host to listen or connect on
 -m,--messageSize <bytes>             size of call parameter in bytes
 -p,--port <port>                     port to listen or connect on
 -r,--serverReaderThreads <threads>   number of server reader threads to run
 -s,--serverThreads <numthreads>      number of server threads (handlers) to run (or 0 to not run
                                      server)
 -t,--time <seconds>                  number of seconds to run clients for
Must specify at least -c or -s
Try "--help" option for details.
{code}
                
> Add standalone benchmark of protobuf IPC
> ----------------------------------------
>
>                 Key: HADOOP-8070
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8070
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: benchmarks, ipc
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.24.0
>
>         Attachments: hadoop-8070.txt
>
>
> To be more comfortable with the switch to protobuf IPC, I'd like to contribute a standalone benchmark which can start any number of client threads and server threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8070) Add standalone benchmark of protobuf IPC

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207964#comment-13207964 ] 

Hudson commented on HADOOP-8070:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #1800 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1800/])
    HADOOP-8070. Add a standalone benchmark for RPC call performance. Contributed by Todd Lipcon. (Revision 1244185)

     Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244185
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/RPCCallBenchmark.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCallBenchmark.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MultithreadedTestUtil.java

                
> Add standalone benchmark of protobuf IPC
> ----------------------------------------
>
>                 Key: HADOOP-8070
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8070
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: benchmarks, ipc
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.24.0
>
>         Attachments: hadoop-8070.txt, hadoop-8070.txt, hadoop-8070.txt
>
>
> To be more comfortable with the switch to protobuf IPC, I'd like to contribute a standalone benchmark which can start any number of client threads and server threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8070) Add standalone benchmark of protobuf IPC

Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-8070:
--------------------------------

    Attachment: hadoop-8070.txt

Improved attachment can also benchmark vs Writable.

Good news is that, at least for this workload, the protobuf implementation is 50% faster (~30k/sec vs ~20k/sec on my laptop)
                
> Add standalone benchmark of protobuf IPC
> ----------------------------------------
>
>                 Key: HADOOP-8070
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8070
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: benchmarks, ipc
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.24.0
>
>         Attachments: hadoop-8070.txt, hadoop-8070.txt
>
>
> To be more comfortable with the switch to protobuf IPC, I'd like to contribute a standalone benchmark which can start any number of client threads and server threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8070) Add standalone benchmark of protobuf IPC

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207991#comment-13207991 ] 

Hudson commented on HADOOP-8070:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #1737 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1737/])
    HADOOP-8070. Add a standalone benchmark for RPC call performance. Contributed by Todd Lipcon. (Revision 1244185)

     Result = ABORTED
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1244185
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/RPCCallBenchmark.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCallBenchmark.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MultithreadedTestUtil.java

                
> Add standalone benchmark of protobuf IPC
> ----------------------------------------
>
>                 Key: HADOOP-8070
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8070
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: benchmarks, ipc
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.24.0
>
>         Attachments: hadoop-8070.txt, hadoop-8070.txt, hadoop-8070.txt
>
>
> To be more comfortable with the switch to protobuf IPC, I'd like to contribute a standalone benchmark which can start any number of client threads and server threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8070) Add standalone benchmark of protobuf IPC

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207507#comment-13207507 ] 

Hadoop QA commented on HADOOP-8070:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12514446/hadoop-8070.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 7 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/591//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/591//console

This message is automatically generated.
                
> Add standalone benchmark of protobuf IPC
> ----------------------------------------
>
>                 Key: HADOOP-8070
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8070
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: benchmarks, ipc
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.24.0
>
>         Attachments: hadoop-8070.txt
>
>
> To be more comfortable with the switch to protobuf IPC, I'd like to contribute a standalone benchmark which can start any number of client threads and server threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira