You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/11/03 04:48:51 UTC
[kudu-CR] [blocking ops] remove extra Socket::IsNonBlocking call
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8454
Change subject: [blocking_ops] remove extra Socket::IsNonBlocking call
......................................................................
[blocking_ops] remove extra Socket::IsNonBlocking call
Removed duplicate call to Socket::IsNonBlocking() from
rpc::SendFramedMessageBlocking().
Change-Id: Iaafe3f2de33f42bad87bbfe7e3ad2ca14cab82d0
---
M src/kudu/rpc/blocking_ops.cc
1 file changed, 4 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/8454/1
--
To view, visit http://gerrit.cloudera.org:8080/8454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaafe3f2de33f42bad87bbfe7e3ad2ca14cab82d0
Gerrit-Change-Number: 8454
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [blocking ops] remove extra Socket::IsNonBlocking call
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8454 )
Change subject: [blocking_ops] remove extra Socket::IsNonBlocking call
......................................................................
[blocking_ops] remove extra Socket::IsNonBlocking call
Removed duplicate call to Socket::IsNonBlocking() from
rpc::SendFramedMessageBlocking().
Change-Id: Iaafe3f2de33f42bad87bbfe7e3ad2ca14cab82d0
Reviewed-on: http://gerrit.cloudera.org:8080/8454
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/rpc/blocking_ops.cc
M src/kudu/rpc/blocking_ops.h
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/server_negotiation.cc
4 files changed, 9 insertions(+), 11 deletions(-)
Approvals:
Alexey Serbin: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaafe3f2de33f42bad87bbfe7e3ad2ca14cab82d0
Gerrit-Change-Number: 8454
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [blocking ops] remove extra Socket::IsNonBlocking call
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8454 )
Change subject: [blocking_ops] remove extra Socket::IsNonBlocking call
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8454/2/src/kudu/rpc/blocking_ops.cc
File src/kudu/rpc/blocking_ops.cc:
http://gerrit.cloudera.org:8080/#/c/8454/2/src/kudu/rpc/blocking_ops.cc@45
PS2, Line 45: EnsureBlockingMode
What do you think about renaming this method CheckInBlockingMode() ? To me, EnsureBlockingMode() implies we will switch to blocking mode if it's not currently in that mode.
--
To view, visit http://gerrit.cloudera.org:8080/8454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaafe3f2de33f42bad87bbfe7e3ad2ca14cab82d0
Gerrit-Change-Number: 8454
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 08 Nov 2017 19:24:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] [blocking ops] remove extra Socket::IsNonBlocking call
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8454
to look at the new patch set (#3).
Change subject: [blocking_ops] remove extra Socket::IsNonBlocking call
......................................................................
[blocking_ops] remove extra Socket::IsNonBlocking call
Removed duplicate call to Socket::IsNonBlocking() from
rpc::SendFramedMessageBlocking().
Change-Id: Iaafe3f2de33f42bad87bbfe7e3ad2ca14cab82d0
---
M src/kudu/rpc/blocking_ops.cc
M src/kudu/rpc/blocking_ops.h
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/server_negotiation.cc
4 files changed, 9 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/8454/3
--
To view, visit http://gerrit.cloudera.org:8080/8454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaafe3f2de33f42bad87bbfe7e3ad2ca14cab82d0
Gerrit-Change-Number: 8454
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [blocking ops] remove extra Socket::IsNonBlocking call
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8454 )
Change subject: [blocking_ops] remove extra Socket::IsNonBlocking call
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaafe3f2de33f42bad87bbfe7e3ad2ca14cab82d0
Gerrit-Change-Number: 8454
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 09 Nov 2017 08:34:46 +0000
Gerrit-HasComments: No
[kudu-CR] [blocking ops] remove extra Socket::IsNonBlocking call
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8454 )
Change subject: [blocking_ops] remove extra Socket::IsNonBlocking call
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8454/2/src/kudu/rpc/blocking_ops.cc
File src/kudu/rpc/blocking_ops.cc:
http://gerrit.cloudera.org:8080/#/c/8454/2/src/kudu/rpc/blocking_ops.cc@45
PS2, Line 45: EnsureBlockingMode
> What do you think about renaming this method CheckInBlockingMode() ? To me,
SGTM
--
To view, visit http://gerrit.cloudera.org:8080/8454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaafe3f2de33f42bad87bbfe7e3ad2ca14cab82d0
Gerrit-Change-Number: 8454
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 08 Nov 2017 20:08:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] [blocking ops] remove extra Socket::IsNonBlocking call
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8454 )
Change subject: [blocking_ops] remove extra Socket::IsNonBlocking call
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Iaafe3f2de33f42bad87bbfe7e3ad2ca14cab82d0
Gerrit-Change-Number: 8454
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [blocking ops] remove extra Socket::IsNonBlocking call
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8454 )
Change subject: [blocking_ops] remove extra Socket::IsNonBlocking call
......................................................................
Patch Set 3: Verified+1
unrelated flake in FlexPartitioningITest.TestFlexPartitioning/34
--
To view, visit http://gerrit.cloudera.org:8080/8454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaafe3f2de33f42bad87bbfe7e3ad2ca14cab82d0
Gerrit-Change-Number: 8454
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 08 Nov 2017 20:39:19 +0000
Gerrit-HasComments: No