[jira] [Commented] (GIRAPH-747) BspServiceMaster finishes ZooKeeper cleanup without waiting for all workers to complete

["Roman Shaposhnik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14044919#comment-14044919 ] 

Roman Shaposhnik commented on GIRAPH-747:
-----------------------------------------

Since no feedback was received -- pushing out of 1.1.0 release.

> BspServiceMaster finishes ZooKeeper cleanup without waiting for all workers to complete
> ---------------------------------------------------------------------------------------
>
>                 Key: GIRAPH-747
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-747
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: Chuan Lei
>            Assignee: Chuan Lei
>         Attachments: GIRAPH-747.v1.patch
>
>
> In BspServiceMaster, the function cleanUpZooKeeper should wait for the number of workers and masters to complete. However, it appears that maxTasks only takes workers into consideration. Consequently, the worker straggler may fail to report to the ZooKeeper due to the path gets removed too early. This will cause No lease on path File does not exist exception at runtime.



--
This message was sent by Atlassian JIRA
(v6.2#6252)