You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "Jzjsnow (via GitHub)" <gi...@apache.org> on 2025/10/11 07:53:22 UTC
[PR] [hotfix] Fix syntax errors in upgrade.sql scripts [amoro]
Jzjsnow opened a new pull request, #3816:
URL: https://github.com/apache/amoro/pull/3816
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
-->
Fixed syntax errors 1 and 2 mentioned in #3815.
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
-
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Fix syntax errors in upgrade.sql scripts [amoro]
Posted by "xxubai (via GitHub)" <gi...@apache.org>.
xxubai commented on code in PR #3816:
URL: https://github.com/apache/amoro/pull/3816#discussion_r2425348439
##########
amoro-ams/src/main/resources/mysql/upgrade.sql:
##########
@@ -144,13 +142,16 @@ INSERT INTO table_runtime_state
SELECT
`table_id`, 'optimizing_state', JSON_OBJECT(
'currentSnapshotId', `current_snapshot_id`,
- 'currentChangeSnapshotId', `current_change_snapshot_id`,
- 'lastOptimizedSnapshotId', `last_optimized_snapshot_id`,
- 'lastOptimizedChangeSnapshotId', `last_optimized_change_snapshot_id`,
+ 'currentChangeSnapshotId', `current_change_snapshotId`,
Review Comment:
Why rename it to `snapshotId`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Hotfix] Fix syntax errors in upgrade.sql scripts [amoro]
Posted by "xxubai (via GitHub)" <gi...@apache.org>.
xxubai merged PR #3816:
URL: https://github.com/apache/amoro/pull/3816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Fix syntax errors in upgrade.sql scripts [amoro]
Posted by "xxubai (via GitHub)" <gi...@apache.org>.
xxubai commented on code in PR #3816:
URL: https://github.com/apache/amoro/pull/3816#discussion_r2425352032
##########
amoro-ams/src/main/resources/mysql/upgrade.sql:
##########
@@ -144,13 +142,16 @@ INSERT INTO table_runtime_state
SELECT
`table_id`, 'optimizing_state', JSON_OBJECT(
'currentSnapshotId', `current_snapshot_id`,
- 'currentChangeSnapshotId', `current_change_snapshot_id`,
- 'lastOptimizedSnapshotId', `last_optimized_snapshot_id`,
- 'lastOptimizedChangeSnapshotId', `last_optimized_change_snapshot_id`,
+ 'currentChangeSnapshotId', `current_change_snapshotId`,
Review Comment:
Ignore this. I see the DDL statements, it is `current_change_snapshotId `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Hotfix] Fix syntax errors in upgrade.sql scripts [amoro]
Posted by "wardlican (via GitHub)" <gi...@apache.org>.
wardlican commented on PR #3816:
URL: https://github.com/apache/amoro/pull/3816#issuecomment-3397067392
> Hi @wardlican, could you check if there would be any issues if @Jzjsnow edits the upgrade SQL statement?
I've seen that the changes here require retaining the newly added bucket_id field, which is used to support the feature #3670, which is still under development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Fix syntax errors in upgrade.sql scripts [amoro]
Posted by "xxubai (via GitHub)" <gi...@apache.org>.
xxubai commented on PR #3816:
URL: https://github.com/apache/amoro/pull/3816#issuecomment-3396075426
Hi @wardlican, could you check if there would be any issues if @Jzjsnow deletes the upgrade SQL statement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org