You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2017/02/10 16:05:00 UTC
Review Request 56547: Deviation alerts fail with "No JSON object
could be decoded"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56547/
-----------------------------------------------------------
Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-19963
https://issues.apache.org/jira/browse/AMBARI-19963
Repository: ambari
Description
-------
Deviation alerts fail with
ERROR 2017-02-09 17:50:12,896 base_alert.py:132 - [Alert][namenode_service_rpc_processing_latency_hourly] Unable to execute alert. No JSON object could be decoded
Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/ambari_agent/alerts/base_alert.py", line 112, in collect
res = self._collect()
File "/usr/lib/python2.6/site-packages/ambari_agent/alerts/script_alert.py", line 115, in _collect
result = cmd_module.execute(configurations, self.parameters, self.host_name)
File "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py", line 326, in execute
data_json = json.loads(data)
File "/usr/lib64/python2.7/json/__init__.py", line 338, in loads
return _default_decoder.decode(s)
File "/usr/lib64/python2.7/json/decoder.py", line 366, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib64/python2.7/json/decoder.py", line 384, in raw_decode
raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded
on AMS with collector HTTPS enabled
Diffs
-----
ambari-common/src/main/python/ambari_commons/network.py PRE-CREATION
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py 84dcd99
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/network.py 672ee53
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py 2bc4363
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py 8a06f56
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/alerts/alert_metrics_deviation.py 8a06f56
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_metrics_deviation.py 1e35e6f
Diff: https://reviews.apache.org/r/56547/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 56547: Deviation alerts fail with "No JSON object
could be decoded"
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56547/#review165146
-----------------------------------------------------------
ambari-common/src/main/python/ambari_commons/network.py (line 26)
<https://reviews.apache.org/r/56547/#comment236956>
Add basic comments.
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/alerts/alert_metrics_deviation.py (line 316)
<https://reviews.apache.org/r/56547/#comment236955>
Is there a config for what this path should be?
- Alejandro Fernandez
On Feb. 10, 2017, 4:04 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56547/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 4:04 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-19963
> https://issues.apache.org/jira/browse/AMBARI-19963
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Deviation alerts fail with
> ERROR 2017-02-09 17:50:12,896 base_alert.py:132 - [Alert][namenode_service_rpc_processing_latency_hourly] Unable to execute alert. No JSON object could be decoded
> Traceback (most recent call last):
> File "/usr/lib/python2.6/site-packages/ambari_agent/alerts/base_alert.py", line 112, in collect
> res = self._collect()
> File "/usr/lib/python2.6/site-packages/ambari_agent/alerts/script_alert.py", line 115, in _collect
> result = cmd_module.execute(configurations, self.parameters, self.host_name)
> File "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py", line 326, in execute
> data_json = json.loads(data)
> File "/usr/lib64/python2.7/json/__init__.py", line 338, in loads
> return _default_decoder.decode(s)
> File "/usr/lib64/python2.7/json/decoder.py", line 366, in decode
> obj, end = self.raw_decode(s, idx=_w(s, 0).end())
> File "/usr/lib64/python2.7/json/decoder.py", line 384, in raw_decode
> raise ValueError("No JSON object could be decoded")
> ValueError: No JSON object could be decoded
> on AMS with collector HTTPS enabled
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/ambari_commons/network.py PRE-CREATION
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py 84dcd99
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/network.py 672ee53
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py 2bc4363
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py 8a06f56
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/alerts/alert_metrics_deviation.py 8a06f56
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_metrics_deviation.py 1e35e6f
>
> Diff: https://reviews.apache.org/r/56547/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 56547: Deviation alerts fail with "No JSON object
could be decoded"
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56547/#review165130
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Feb. 10, 2017, 4:04 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56547/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 4:04 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-19963
> https://issues.apache.org/jira/browse/AMBARI-19963
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Deviation alerts fail with
> ERROR 2017-02-09 17:50:12,896 base_alert.py:132 - [Alert][namenode_service_rpc_processing_latency_hourly] Unable to execute alert. No JSON object could be decoded
> Traceback (most recent call last):
> File "/usr/lib/python2.6/site-packages/ambari_agent/alerts/base_alert.py", line 112, in collect
> res = self._collect()
> File "/usr/lib/python2.6/site-packages/ambari_agent/alerts/script_alert.py", line 115, in _collect
> result = cmd_module.execute(configurations, self.parameters, self.host_name)
> File "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py", line 326, in execute
> data_json = json.loads(data)
> File "/usr/lib64/python2.7/json/__init__.py", line 338, in loads
> return _default_decoder.decode(s)
> File "/usr/lib64/python2.7/json/decoder.py", line 366, in decode
> obj, end = self.raw_decode(s, idx=_w(s, 0).end())
> File "/usr/lib64/python2.7/json/decoder.py", line 384, in raw_decode
> raise ValueError("No JSON object could be decoded")
> ValueError: No JSON object could be decoded
> on AMS with collector HTTPS enabled
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/ambari_commons/network.py PRE-CREATION
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py 84dcd99
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/network.py 672ee53
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py 2bc4363
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py 8a06f56
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/alerts/alert_metrics_deviation.py 8a06f56
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_metrics_deviation.py 1e35e6f
>
> Diff: https://reviews.apache.org/r/56547/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>