[GitHub] [pulsar] nodece commented on a change in pull request #14798: [improve][security] Add load multiple certificates support

[GitBox <gi...@apache.org>]

nodece commented on a change in pull request #14798:
URL: https://github.com/apache/pulsar/pull/14798#discussion_r832792425



##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/TrustManagerProxy.java
##########
@@ -74,11 +76,16 @@ private void updateTrustManager() throws CertificateException, KeyStoreException
             FileNotFoundException, IOException {
         CertificateFactory factory = CertificateFactory.getInstance("X.509");
         try (InputStream inputStream = new FileInputStream(certFile.getFileName())) {
-            X509Certificate certificate = (X509Certificate) factory.generateCertificate(inputStream);
-            String alias = certificate.getSubjectX500Principal().getName();
             KeyStore keyStore = KeyStore.getInstance("JKS");

Review comment:
       We should pass the KeyStore type to `TrustManagerProxy`, right now we are using JKS.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org