You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/12/15 17:58:36 UTC

[GitHub] [camel-quarkus] djencks commented on a change in pull request #3385: POC/WIP local build setup

djencks commented on a change in pull request #3385:
URL: https://github.com/apache/camel-quarkus/pull/3385#discussion_r769862992



##########
File path: docs/pom.xml
##########
@@ -85,45 +85,45 @@
             </activation>
             <build>
                 <plugins>
-                    <plugin>
-                        <groupId>com.github.eirslett</groupId>
-                        <artifactId>frontend-maven-plugin</artifactId>
-                        <version>${frontend-maven-plugin.version}</version>
-                        <executions>
-                            <execution>
-                                <id>install node and yarn</id>
-                                <goals>
-                                    <goal>install-node-and-yarn</goal>
-                                </goals>
-                                <configuration>
-                                    <nodeVersion>v14.16.0</nodeVersion>
-                                    <yarnVersion>v1.22.5</yarnVersion>
-                                </configuration>
-                            </execution>
-                            <execution>
-                                <id>yarn install</id>
-                                <goals>
-                                    <goal>yarn</goal>
-                                </goals>
-                                <phase>verify</phase>
-                                <configuration>
-                                    <arguments>install --immutable</arguments>
-                                </configuration>
-                            </execution>
-                            <!-- TODO: Enable checks once docs issues are fixed https://github.com/apache/camel-quarkus/issues/3307
-                            <execution>
-                                <id>antora-xref-check</id>
-                                <goals>
-                                    <goal>yarn</goal>
-                                </goals>
-                                <phase>verify</phase>
-                                <configuration>
-                                    <arguments>run checks</arguments>
-                                </configuration>
-                            </execution>
-                            -->
-                        </executions>
-                    </plugin>
+<!--                    <plugin>-->

Review comment:
       There's no point in keeping it's current state, but I left it there to help me think about whether there's a plausible way to do a partial docs build as part of the maven build... so far I don't see a good way.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org