[GitHub] [kafka] TomerWizman commented on a change in pull request #11250: Kafka 12766 - Disabling WAL-related Options in RocksDB

[GitBox <gi...@apache.org>]

TomerWizman commented on a change in pull request #11250:
URL: https://github.com/apache/kafka/pull/11250#discussion_r694529457



##########
File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##########
@@ -304,7 +306,7 @@ public String walDir() {
 
     @Override
     public Options setWalDir(final String walDir) {
-        dbOptions.setWalDir(walDir);
+        LOGGER.warn("WAL is explicitly disabled by Streams in RocksDB. Setting option 'walDir' will be ignored");

Review comment:
       sounds like a good suggestion. I can extract the logging to a helper method. I think the return behaviour should still remain under the responsibility of the setters. Let me know what you think 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org