You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/01/26 13:22:12 UTC

[PR] Only use `datafusion` crate in the examples [datafusion]

alamb opened a new pull request, #14305:
URL: https://github.com/apache/datafusion/pull/14305

   ## Which issue does this PR close?
   
   - part of #7013 
   - Follow on to https://github.com/apache/datafusion/pull/14300#discussion_r1929726700 with @berkaysynnada 
   - Related to https://github.com/apache/datafusion/pull/14304
   
   ## Rationale for this change
   
   DataFusion is largely intended to be used via the `datafusion` crate. It is split into multiple subcrates largely for project organization rather than for users to use subcrates
   
   The examples currently use many of the datafusion subcrates (e.g. `datafusion_common`) directly. This is non ideal because
   1. It may confuse users who try to follow the examples and lead them incorrectly towards using the subcrates directly
   2. It may potentially mask issues where a struct is not publicly exported
   
   Thus I think our examples should only use the DataFusion crate
   
   
   ## What changes are included in this PR?
   1. Update the exmaples to use (only) `datafusion`
   2. Re-export `ApplyOrder` in datafusion::optimizer to make it easier to use
   
   ## Are these changes tested?
   Yes, by CI
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   3. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Export `datafusion_physical_optimizer`, only use `datafusion` crate in the examples [datafusion]

Posted by "berkaysynnada (via GitHub)" <gi...@apache.org>.
berkaysynnada merged PR #14305:
URL: https://github.com/apache/datafusion/pull/14305


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org