[GitHub] [arrow] kou commented on a diff in pull request #14059: ARROW-17632: [Python][C++] Add details of where libarrow is being found during build

[GitBox <gi...@apache.org>]

kou commented on code in PR #14059:
URL: https://github.com/apache/arrow/pull/14059#discussion_r964483581


##########
cpp/src/arrow/ArrowConfig.cmake.in:
##########
@@ -172,3 +172,12 @@ endmacro()
 arrow_keep_backward_compatibility(Arrow arrow)
 
 check_required_components(Arrow)
+
+if(NOT Arrow_FIND_QUIETLY)
+  message(STATUS "Arrow version: ${ARROW_VERSION} (${ARROW_FIND_APPROACH})")

Review Comment:
   `ARROW_FIND_APPROACH` is meaningless in the new our CMake packages.



##########
cpp/src/arrow/ArrowConfig.cmake.in:
##########
@@ -172,3 +172,12 @@ endmacro()
 arrow_keep_backward_compatibility(Arrow arrow)
 
 check_required_components(Arrow)
+
+if(NOT Arrow_FIND_QUIETLY)
+  message(STATUS "Arrow version: ${ARROW_VERSION} (${ARROW_FIND_APPROACH})")
+  message(STATUS "Arrow SO and ABI version: ${ARROW_SO_VERSION}")
+  message(STATUS "Arrow full SO version: ${ARROW_FULL_SO_VERSION}")
+  message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}")
+  message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}")
+  message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}")
+endif()

Review Comment:
   Could you define a function `arrow_show_details(package_name)` or something that shows these status messages and use it in all `*Config.cmake.in`?



##########
cpp/src/arrow/ArrowConfig.cmake.in:
##########
@@ -172,3 +172,12 @@ endmacro()
 arrow_keep_backward_compatibility(Arrow arrow)
 
 check_required_components(Arrow)
+
+if(NOT Arrow_FIND_QUIETLY)
+  message(STATUS "Arrow version: ${ARROW_VERSION} (${ARROW_FIND_APPROACH})")
+  message(STATUS "Arrow SO and ABI version: ${ARROW_SO_VERSION}")
+  message(STATUS "Arrow full SO version: ${ARROW_FULL_SO_VERSION}")

Review Comment:
   I think that we don't need them because `SHARED_LIB` has these information in its extension.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org