You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tiles.apache.org by "David Smith (JIRA)" <ji...@apache.org> on 2009/10/05 18:02:51 UTC

[jira] Created: (TILES-475) Add wildcard support to the extends attribute of the tile definition

Add wildcard support to the extends attribute of the tile definition
--------------------------------------------------------------------

                 Key: TILES-475
                 URL: https://issues.apache.org/struts/browse/TILES-475
             Project: Tiles
          Issue Type: Improvement
    Affects Versions: 2.2.0, 2.1.3
            Reporter: David Smith



Add wildcard support to the extends attribute of the tile definition.

      <definition name="sales_rates_application.layout" extends="general.logon.layout">
            <put-attribute name="title_page_name" value="Sales Rates" />
      </definition>     

      <definition name="*_kickoff.page" extends="{1}_application.layout">
            <put-attribute name="body" value="/pages/{1}/{1}_kickoff.jsp" />
      </definition>

where * = sales_rates

Email from user group wildcard discussion on 10/05/2009:

> Yet you can have a wildcard in the template definition. Isn't the 
> parent just an extension of the template.

The parent should be considered a half-filled template.
However, I changed my mind. It is difficult to do, but not impossible, the wildcard-based definitions should be evaluated and resolved only when requested.
Can you open a JIRA issue please? And if you want to submit a patch, you're welcome :-D

Ciao
Antonio




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TILES-475) Add wildcard support to the extends attribute of the tile definition

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli updated TILES-475:
-----------------------------------

    Fix Version/s: 2.2.1

> Add wildcard support to the extends attribute of the tile definition
> --------------------------------------------------------------------
>
>                 Key: TILES-475
>                 URL: https://issues.apache.org/struts/browse/TILES-475
>             Project: Tiles
>          Issue Type: Improvement
>    Affects Versions: 2.1.3, 2.2.0
>            Reporter: David Smith
>            Assignee: Antonio Petrelli
>             Fix For: 2.1.4, 2.2.1
>
>
> Add wildcard support to the extends attribute of the tile definition.
>       <definition name="sales_rates_application.layout" extends="general.logon.layout">
>             <put-attribute name="title_page_name" value="Sales Rates" />
>       </definition>     
>       <definition name="*_kickoff.page" extends="{1}_application.layout">
>             <put-attribute name="body" value="/pages/{1}/{1}_kickoff.jsp" />
>       </definition>
> where * = sales_rates
> Email from user group wildcard discussion on 10/05/2009:
> > Yet you can have a wildcard in the template definition. Isn't the 
> > parent just an extension of the template.
> The parent should be considered a half-filled template.
> However, I changed my mind. It is difficult to do, but not impossible, the wildcard-based definitions should be evaluated and resolved only when requested.
> Can you open a JIRA issue please? And if you want to submit a patch, you're welcome :-D
> Ciao
> Antonio

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TILES-475) Add wildcard support to the extends attribute of the tile definition

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli updated TILES-475:
-----------------------------------

    Fix Version/s:     (was: 2.1.4)

> Add wildcard support to the extends attribute of the tile definition
> --------------------------------------------------------------------
>
>                 Key: TILES-475
>                 URL: https://issues.apache.org/struts/browse/TILES-475
>             Project: Tiles
>          Issue Type: Improvement
>    Affects Versions: 2.1.3, 2.2.0
>            Reporter: David Smith
>            Assignee: Antonio Petrelli
>             Fix For: 2.2.1
>
>
> Add wildcard support to the extends attribute of the tile definition.
>       <definition name="sales_rates_application.layout" extends="general.logon.layout">
>             <put-attribute name="title_page_name" value="Sales Rates" />
>       </definition>     
>       <definition name="*_kickoff.page" extends="{1}_application.layout">
>             <put-attribute name="body" value="/pages/{1}/{1}_kickoff.jsp" />
>       </definition>
> where * = sales_rates
> Email from user group wildcard discussion on 10/05/2009:
> > Yet you can have a wildcard in the template definition. Isn't the 
> > parent just an extension of the template.
> The parent should be considered a half-filled template.
> However, I changed my mind. It is difficult to do, but not impossible, the wildcard-based definitions should be evaluated and resolved only when requested.
> Can you open a JIRA issue please? And if you want to submit a patch, you're welcome :-D
> Ciao
> Antonio

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TILES-475) Add wildcard support to the extends attribute of the tile definition

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli updated TILES-475:
-----------------------------------

    Fix Version/s: 2.1.4

> Add wildcard support to the extends attribute of the tile definition
> --------------------------------------------------------------------
>
>                 Key: TILES-475
>                 URL: https://issues.apache.org/struts/browse/TILES-475
>             Project: Tiles
>          Issue Type: Improvement
>    Affects Versions: 2.1.3, 2.2.0
>            Reporter: David Smith
>            Assignee: Antonio Petrelli
>             Fix For: 2.1.4
>
>
> Add wildcard support to the extends attribute of the tile definition.
>       <definition name="sales_rates_application.layout" extends="general.logon.layout">
>             <put-attribute name="title_page_name" value="Sales Rates" />
>       </definition>     
>       <definition name="*_kickoff.page" extends="{1}_application.layout">
>             <put-attribute name="body" value="/pages/{1}/{1}_kickoff.jsp" />
>       </definition>
> where * = sales_rates
> Email from user group wildcard discussion on 10/05/2009:
> > Yet you can have a wildcard in the template definition. Isn't the 
> > parent just an extension of the template.
> The parent should be considered a half-filled template.
> However, I changed my mind. It is difficult to do, but not impossible, the wildcard-based definitions should be evaluated and resolved only when requested.
> Can you open a JIRA issue please? And if you want to submit a patch, you're welcome :-D
> Ciao
> Antonio

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TILES-475) Add wildcard support to the extends attribute of the tile definition

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli updated TILES-475:
-----------------------------------

    Assignee: Antonio Petrelli

> Add wildcard support to the extends attribute of the tile definition
> --------------------------------------------------------------------
>
>                 Key: TILES-475
>                 URL: https://issues.apache.org/struts/browse/TILES-475
>             Project: Tiles
>          Issue Type: Improvement
>    Affects Versions: 2.1.3, 2.2.0
>            Reporter: David Smith
>            Assignee: Antonio Petrelli
>
> Add wildcard support to the extends attribute of the tile definition.
>       <definition name="sales_rates_application.layout" extends="general.logon.layout">
>             <put-attribute name="title_page_name" value="Sales Rates" />
>       </definition>     
>       <definition name="*_kickoff.page" extends="{1}_application.layout">
>             <put-attribute name="body" value="/pages/{1}/{1}_kickoff.jsp" />
>       </definition>
> where * = sales_rates
> Email from user group wildcard discussion on 10/05/2009:
> > Yet you can have a wildcard in the template definition. Isn't the 
> > parent just an extension of the template.
> The parent should be considered a half-filled template.
> However, I changed my mind. It is difficult to do, but not impossible, the wildcard-based definitions should be evaluated and resolved only when requested.
> Can you open a JIRA issue please? And if you want to submit a patch, you're welcome :-D
> Ciao
> Antonio

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (TILES-475) Add wildcard support to the extends attribute of the tile definition

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli closed TILES-475.
----------------------------------

    Resolution: Fixed

> Add wildcard support to the extends attribute of the tile definition
> --------------------------------------------------------------------
>
>                 Key: TILES-475
>                 URL: https://issues.apache.org/struts/browse/TILES-475
>             Project: Tiles
>          Issue Type: Improvement
>    Affects Versions: 2.1.3, 2.2.0
>            Reporter: David Smith
>            Assignee: Antonio Petrelli
>
> Add wildcard support to the extends attribute of the tile definition.
>       <definition name="sales_rates_application.layout" extends="general.logon.layout">
>             <put-attribute name="title_page_name" value="Sales Rates" />
>       </definition>     
>       <definition name="*_kickoff.page" extends="{1}_application.layout">
>             <put-attribute name="body" value="/pages/{1}/{1}_kickoff.jsp" />
>       </definition>
> where * = sales_rates
> Email from user group wildcard discussion on 10/05/2009:
> > Yet you can have a wildcard in the template definition. Isn't the 
> > parent just an extension of the template.
> The parent should be considered a half-filled template.
> However, I changed my mind. It is difficult to do, but not impossible, the wildcard-based definitions should be evaluated and resolved only when requested.
> Can you open a JIRA issue please? And if you want to submit a patch, you're welcome :-D
> Ciao
> Antonio

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TILES-475) Add wildcard support to the extends attribute of the tile definition

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli updated TILES-475:
-----------------------------------


The support for extension mechanism using CachingLocaleUrlDefinitionDAO was already present, but I added some test cases.
However it did not work with ResolvingLocaleUrlDefinitionDAO, so I fixed it by bypassing first-pass-inheritance and delaying inheritance resolution at request time.

> Add wildcard support to the extends attribute of the tile definition
> --------------------------------------------------------------------
>
>                 Key: TILES-475
>                 URL: https://issues.apache.org/struts/browse/TILES-475
>             Project: Tiles
>          Issue Type: Improvement
>    Affects Versions: 2.1.3, 2.2.0
>            Reporter: David Smith
>            Assignee: Antonio Petrelli
>
> Add wildcard support to the extends attribute of the tile definition.
>       <definition name="sales_rates_application.layout" extends="general.logon.layout">
>             <put-attribute name="title_page_name" value="Sales Rates" />
>       </definition>     
>       <definition name="*_kickoff.page" extends="{1}_application.layout">
>             <put-attribute name="body" value="/pages/{1}/{1}_kickoff.jsp" />
>       </definition>
> where * = sales_rates
> Email from user group wildcard discussion on 10/05/2009:
> > Yet you can have a wildcard in the template definition. Isn't the 
> > parent just an extension of the template.
> The parent should be considered a half-filled template.
> However, I changed my mind. It is difficult to do, but not impossible, the wildcard-based definitions should be evaluated and resolved only when requested.
> Can you open a JIRA issue please? And if you want to submit a patch, you're welcome :-D
> Ciao
> Antonio

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.