[GitHub] [ozone] dombizita commented on a diff in pull request #3468: HDDS-6783. Recon tasks should write in batches to their databases

[GitBox <gi...@apache.org>]

dombizita commented on code in PR #3468:
URL: https://github.com/apache/ozone/pull/3468#discussion_r891081424


##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/ReconContainerMetadataManager.java:
##########
@@ -53,6 +55,17 @@ void reinitWithNewContainerDataFromOm(Map<ContainerKeyPrefix, Integer>
   void storeContainerKeyMapping(ContainerKeyPrefix containerKeyPrefix,

Review Comment:
   Thanks for this comment, this is a good idea. I changed the unit tests in both the `TestReconContainerMetadataManagerImpl` and the `TestReconNamespaceSummaryManagerImpl` (and in the `TestNSSummaryTask`) to use batch version, instead of the simple store. I added the `@Deprecated` annotation to all the simple store methods.



##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/ReconContainerMetadataManager.java:
##########
@@ -190,4 +225,7 @@ void deleteContainerMapping(ContainerKeyPrefix containerKeyPrefix)
    */
   void incrementContainerCountBy(long count);
 
+  void commitBatchOperation(RDBBatchOperation rdbBatchOperation)

Review Comment:
   Thanks, done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org