You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by Matthias Wessendorf <ma...@apache.org> on 2010/04/24 15:06:45 UTC
Re: BeanManagerImpl -> "improvement" on WebBeansConfigurationException
?
ok, thanks
REV: 937626
-M
On Sat, Apr 24, 2010 at 2:42 PM, Gurkan Erdogdu <gu...@yahoo.com> wrote:
> Thanks a lot Matthias! Also congratulations for JSF 2.0.0 release.
>
>
> --Gurkan
>
>
> ________________________________
> From: Matthias Wessendorf <ma...@apache.org>
> To: dev@openwebbeans.apache.org
> Sent: Fri, April 23, 2010 11:36:35 PM
> Subject: BeanManagerImpl -> "improvement" on WebBeansConfigurationException ?
>
> Hi,
>
> I think that on the BeanManagerImpl class there is (some) room for improvements.
> Below is a patch to have a slightly "better" exception text.
>
> Does one mind if I commit that ?
>
> Thanks!
> Matthias
>
>
>
> Index: webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
> ===================================================================
> --- webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java (revision
> 937508)
> +++ webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java (working
> copy)
> @@ -1008,7 +1008,7 @@
> {
> if (!bean.getScope().equals(Dependent.class))
> {
> - throw new WebBeansConfigurationException("Bean "
> + bean + "scope can not define other scope except @Dependent to inject
> InjectionPoint");
> + throw new WebBeansConfigurationException("Bean "
> + bean.getBeanClass() + " scope can not define other scope except
> @Dependent to inject InjectionPoint");
> }
> }
> }
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
>
>
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf