You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by danbroudy <no...@github.com> on 2014/12/06 03:35:26 UTC

[jclouds-labs-google] Updates to InstanceApi. 100% coverage (#110)

InstanceApi is still lacking some LiveTest Coverage.
You can merge this Pull Request by running:

  git pull https://github.com/GoogleCloudPlatform/jclouds-labs-google detailCleanPartII

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-google/pull/110

-- Commit Summary --

  * Updates to InstanceApi. 100% coverage

-- File Changes --

    M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceAdapter.java (2)
    M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/AttachDisk.java (31)
    M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Instance.java (37)
    M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/NewInstance.java (18)
    M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/InstanceApi.java (8)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiLiveTest.java (28)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiMockTest.java (54)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseInstanceSerialOutputTest.java (11)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseInstanceTest.java (14)
    M google-compute-engine/src/test/resources/instance_attach_disk.json (21)
    M google-compute-engine/src/test/resources/instance_get.json (13)
    M google-compute-engine/src/test/resources/instance_list.json (155)
    M google-compute-engine/src/test/resources/instance_serial_port.json (5)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-google/pull/110.patch
https://github.com/jclouds/jclouds-labs-google/pull/110.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/110

Re: [jclouds-labs-google] Updates to InstanceApi. 100% coverage (#110)

Posted by danbroudy <no...@github.com>.
You are correct. This should change. I think NewInstance needs a Builder pattern so that you can customize new instances more than the two creation options there are now. 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/110#issuecomment-101749778

Re: [jclouds-labs-google] Updates to InstanceApi. 100% coverage (#110)

Posted by Pedro Ribeiro <no...@github.com>.
This follow up issue has been created: https://issues.apache.org/jira/browse/JCLOUDS-906

Unfortunately, even though this would make my life much easier, I probably won't have the time to contribute a patch. :/

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/110#issuecomment-101989726

Re: [jclouds-labs-google] Updates to InstanceApi. 100% coverage (#110)

Posted by Ignasi Barrera <no...@github.com>.
@pedro-ribeiro Do you mean that there should be a way in the ComputeService to propagate the service accounts [here](https://github.com/jclouds/jclouds-labs-google/blob/master/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceAdapter.java#L165)?

I'm not the GCE expert, but this is something that could be easily added to the GCETemplateOptions and considered there. If that is the case, mind opening a JIRA improvement for this? And even better would you like to try contributing that patch? :)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/110#issuecomment-101818706

Re: [jclouds-labs-google] Updates to InstanceApi. 100% coverage (#110)

Posted by Ignasi Barrera <no...@github.com>.
Pushed to master as [8e4a17f](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-google.git;a=commit;h=8e4a17f57092760cc04243514b49365cd98ffd07). Thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/110#issuecomment-66316740

Re: [jclouds-labs-google] Updates to InstanceApi. 100% coverage (#110)

Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds-labs-google #1845](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1845/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/110#issuecomment-65882575

Re: [jclouds-labs-google] Updates to InstanceApi. 100% coverage (#110)

Posted by Pedro Ribeiro <no...@github.com>.
@danbroudy, if I'm looking at this right, a serviceAccounts field was added to NewInstance, but no further wiring was done and the library does not provide a way to set this value on node creation. Was this on purpose or just lack of time?

Thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/110#issuecomment-101741868

Re: [jclouds-labs-google] Updates to InstanceApi. 100% coverage (#110)

Posted by danbroudy <no...@github.com>.
#142 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/110#issuecomment-106930345

Re: [jclouds-labs-google] Updates to InstanceApi. 100% coverage (#110)

Posted by Ignasi Barrera <no...@github.com>.
Closed #110.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/110#event-204977245