You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/17 15:57:19 UTC

[GitHub] [tvm] mbaret commented on a change in pull request #6982: [ETHOSN] Add support for default Ethos-N78 configuration.

mbaret commented on a change in pull request #6982:
URL: https://github.com/apache/tvm/pull/6982#discussion_r577730954



##########
File path: tests/python/contrib/test_ethosn/test_networks.py
##########
@@ -125,6 +125,8 @@ def test_mobilenet_v1():
     _compile_hash = {"81637c89339201a07dc96e3b5dbf836a"}
     if tei.get_ethosn_api_version() == 2008:
         _compile_hash = {"47e216d8ab2bf491708ccf5620bc0d02"}
+        if tei.get_ethosn_variant() == 3:

Review comment:
       This looks like it's getting out-of-hand to me. How many 'variant' hashes are there going to ultimately be, and when can we get rid of hashes from old versions?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org