You are viewing a plain text version of this content. The canonical link for it is here.
Posted to j-dev@xerces.apache.org by "K. Venugopal" <k....@sun.com> on 2003/04/24 11:02:23 UTC

Patch for bug 19211

Hi ,

    Please find patch for bug 19211 attached .

Regards
venu


Re: Patch for bug 19211

Posted by "K. Venugopal" <k....@sun.com>.
Hi Elena ,

Testcase for bug 19211 is attached .Please change hardcoded values in 
.java and xml files appropriately .

Regards
venu

Elena Litani wrote:

>Hi Venu, 
>
>"K. Venugopal" wrote:
>  
>
>>    Please find patch for bug 19211 attached .
>>    
>>
>
>I can't reproduce the bug you've reported: I've modified the sample XML
>document, defining external entity 'familytree' with empty content and
>using XMLSerializer to serialize the document or dom.Count. 
>
>Please, provide a sample code to reporduce the problem.
>
>Thank you,
>  
>


Re: Patch for bug 19211

Posted by Elena Litani <el...@ca.ibm.com>.
Hi Venu, 

"K. Venugopal" wrote:
>     Please find patch for bug 19211 attached .

I can't reproduce the bug you've reported: I've modified the sample XML
document, defining external entity 'familytree' with empty content and
using XMLSerializer to serialize the document or dom.Count. 

Please, provide a sample code to reporduce the problem.

Thank you,
-- 
Elena Litani / IBM Toronto

---------------------------------------------------------------------
To unsubscribe, e-mail: xerces-j-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xerces-j-dev-help@xml.apache.org


Re: Patch for bug 19211

Posted by Neeraj Bajaj <ne...@sun.com>.
Hi Venu,

            I have committed your patch.

Thanks
Neeraj


>
>     Please find patch for bug 19211 attached .
>
> Regards
> venu
>
>   ------------------------------------------------------------------------
> Index: AbstractDOMParser.java
> ===================================================================
> RCS file: /home/cvspublic/xml-xerces/java/src/org/apache/xerces/parsers/AbstractDOMParser.java,v
> retrieving revision 1.84
> diff -u -r1.84 AbstractDOMParser.java
> --- AbstractDOMParser.java      24 Mar 2003 14:28:44 -0000      1.84
> +++ AbstractDOMParser.java      24 Apr 2003 08:40:08 -0000
> @@ -1586,7 +1586,12 @@
>                       prevIndex = childIndex;
>                       childIndex = sibling;
>                   }
> -                 fDeferredDocumentImpl.setAsLastChild(parentIndex, lastChild);
> +                                if(lastChild != -1)
> +                        fDeferredDocumentImpl.setAsLastChild(parentIndex, lastChild);
> +                               else{
> +                     sibling = fDeferredDocumentImpl.getRealPrevSibling(prevIndex, false);
> +                        fDeferredDocumentImpl.setAsLastChild(parentIndex, sibling);
> +                               }
>                   fCurrentNodeIndex = parentIndex;
>               }
>               fDeferredEntityDecl = -1;
>
>   ------------------------------------------------------------------------
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: xerces-j-dev-unsubscribe@xml.apache.org
> For additional commands, e-mail: xerces-j-dev-help@xml.apache.org

-- Neeraj