[orchestra] ConversationContext.removeConversation

[simon <sk...@apache.org>]

Hi,

We have this method in ConversationContext:

/**
 * Remove the conversation from this context.
 * 
 * <p>Notice: It is assumed that the conversation has already been
invalidated.</p>
 */
protected void removeConversation(Conversation conversation)
{
	synchronized (this)
	{
		touch();
		conversations.remove(conversation.getName());
	}
}

If the conversation is assumed to be invalidated, then perhaps we should
check, and throw an exception if it is not? What do you think?

It is currently called only from the Conversation.destroy() method and
ConversationManager.removeConversation. In the first case, the
conversation is definitely invalidated. In the second, there do not
appear to be any existing callers of that method.

Regards, Simon