You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "pvary (via GitHub)" <gi...@apache.org> on 2024/07/29 06:46:21 UTC

[PR] Flink: Disabling flaky test TestIcebergSourceFailover.testBoundedWithSavepoint [iceberg]

pvary opened a new pull request, #10802:
URL: https://github.com/apache/iceberg/pull/10802

   Disabling flaky tests.
   #10671


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Flink: Disabling flaky test TestIcebergSourceFailover.testBoundedWithSavepoint [iceberg]

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #10802:
URL: https://github.com/apache/iceberg/pull/10802#discussion_r1694709068


##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -137,6 +138,7 @@ protected void assertRecords(Table table, List<Record> expectedRecords, Duration
     SimpleDataUtil.assertTableRecords(table, expectedRecords, timeout);
   }
 
+  @Disabled("Disabled for now as it is flaky on CI")

Review Comment:
   nvm, there is https://github.com/apache/iceberg/issues/10671 to track that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Flink: Disabling flaky test TestIcebergSourceFailover.testBoundedWithSavepoint [iceberg]

Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on PR #10802:
URL: https://github.com/apache/iceberg/pull/10802#issuecomment-2255275307

   Thanks for the review @nastra!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Flink: Disabling flaky test TestIcebergSourceFailover.testBoundedWithSavepoint [iceberg]

Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary merged PR #10802:
URL: https://github.com/apache/iceberg/pull/10802


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Flink: Disabling flaky test TestIcebergSourceFailover.testBoundedWithSavepoint [iceberg]

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #10802:
URL: https://github.com/apache/iceberg/pull/10802#discussion_r1694699704


##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -137,6 +138,7 @@ protected void assertRecords(Table table, List<Record> expectedRecords, Duration
     SimpleDataUtil.assertTableRecords(table, expectedRecords, timeout);
   }
 
+  @Disabled("Disabled for now as it is flaky on CI")

Review Comment:
   do we have an issue to investigate/fix the flakiness? I just want to make sure we don't lose track of enabling this again



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org