You are viewing a plain text version of this content. The canonical link for it is here.
Posted to npanday-dev@incubator.apache.org by Brett Porter <br...@apache.org> on 2010/10/27 01:46:42 UTC

Re: svn commit: r1024525 [1/8] - in /incubator/npanday/npanday-its/trunk/src/test: java/npanday/its/ resources/NPanday330MVC2010ProjectTest/ resources/NPanday330MVC2010ProjectTest/NPanday330MVC2010ProjectTest/ resources/NPanday330MVC2010ProjectTest/NPanday...

On 20/10/2010, at 4:14 PM, apadilla@apache.org wrote:

> +    public NPandayIT330MVC2010ProjectTest()
> +    {
> +        super( "[1.2,)", "[v4.0.30319,)" ); 

This version range should be higher as in other cases.

> +
> +        File f = new File( System.getenv( "SYSTEMROOT" ), "assembly/GAC_MSIL/System.Web.MVC" );
> +        if ( !f.exists() || !f.isDirectory() )
> +        {
> +            skipReason = "MVC.NET is not installed";
> +            skip = true;
> +        }

Is this correct for VS 2010 only? I think it was using a different GAC location?
> 
> Added: incubator/npanday/npanday-its/trunk/src/test/resources/NPanday330MVC2010ProjectTest/NPanday330MVC2010ProjectTest/Models/AccountModels.cs
> URL: http://svn.apache.org/viewvc/incubator/npanday/npanday-its/trunk/src/test/resources/NPanday330MVC2010ProjectTest/NPanday330MVC2010ProjectTest/Models/AccountModels.cs?rev=1024525&view=auto
> ==============================================================================
> --- incubator/npanday/npanday-its/trunk/src/test/resources/NPanday330MVC2010ProjectTest/NPanday330MVC2010ProjectTest/Models/AccountModels.cs (added)
> +++ incubator/npanday/npanday-its/trunk/src/test/resources/NPanday330MVC2010ProjectTest/NPanday330MVC2010ProjectTest/Models/AccountModels.cs Wed Oct 20 05:14:10 2010

Do we need that much sample code for the IT? Not sure where it came from, is it a generated template project? It seems unclear if some of the later AJAX code is actually able to be checked in here.

> +    [PropertiesMustMatch("Password", "ConfirmPassword", ErrorMessage = "The password and confirmation password do not match.")]
> +    public class RegisterModel
> +    {
> +        [Required]
> +  Author: apadilla
> Date: Wed Oct 20 05:14:10 2010
> New Revision: 1024525

This is a bit weird - do you know what happened?

- Brett

--
Brett Porter
brett@apache.org
http://brettporter.wordpress.com/