[GitHub] [arrow-datafusion] crepererum commented on a diff in pull request #6682: Minor: combine `dataframe` and `dataframe_functions` tests to save build time and builder disk space

["crepererum (via GitHub)" <gi...@apache.org>]

crepererum commented on code in PR #6682:
URL: https://github.com/apache/arrow-datafusion/pull/6682#discussion_r1232024517


##########
datafusion/core/tests/dataframe.rs:
##########
@@ -1267,3 +1266,676 @@ async fn use_var_provider() -> Result<()> {
     dataframe.collect().await?;
     Ok(())
 }
+
+// --------------- Begin dataframe function tests ----------------

Review Comment:
   I suggest you put these into rust modules instead. The issue w/ disk space is NOT that they are in different files but that you have two test binaries.
   
   File struct is:
   
   - `dataframe.rs`:
      ```rust
      mod dataframe;
      mod dataframe_functions;
      ```
   - `dataframe/dataframe.rs`
   - `dataframe/dataframe_functions.rs`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org