[GitHub] [incubator-superset] mistercrunch commented on pull request #10480: fix(#10479): dashboard slug is cleared on import

[GitBox <gi...@apache.org>]

mistercrunch commented on pull request #10480:
URL: https://github.com/apache/incubator-superset/pull/10480#issuecomment-669638044


   So the question remains: if the slug exist, what do you do? Overwrite or Insert?
   
   The desired behavior is generally to overwrite. BUT! What if there's a collision on a generic name like `sales`, and someone overwrite someone else's dashboard?
   
   I know in the code there's currently brittle logic around the "remote id" that gets stored in the target. Unlike uuids, they are not universally unique so it's not great. It also looked like the logic around it didn't work well since I was getting a unique constraint error.
   
   With this *fix*, are you not getting a unique constraint error if you load the same dashobard twice?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org