You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2013/01/30 16:05:18 UTC
Review Request: Cloudstack-711 Cpu and ram overcommit at cluster level.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9156/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek, Prachi Damle, and Nitin Mehta.
Summary (updated)
-----------------
Cloudstack-711 Cpu and ram overcommit at cluster level.
Description (updated)
-------
This patch enables cpu and ram overcommit on a per cluster basis(only for xenserver.).
The dashboard will show actual values instead of the overcommit values.
This addresses bug CLOUDSTACK-711.
Diffs (updated)
-----
api/src/com/cloud/vm/VirtualMachineProfile.java 0fab443
api/src/org/apache/cloudstack/api/ApiConstants.java 58a7831
api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c64883c
api/src/org/apache/cloudstack/api/response/ClusterResponse.java e436c99
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 065d3be
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 58b8a03
server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java 2a5258c
server/src/com/cloud/api/ApiDBUtils.java 0b08b26
server/src/com/cloud/api/ApiResponseHelper.java 1c8849a
server/src/com/cloud/capacity/CapacityManager.java fffb41f
server/src/com/cloud/capacity/CapacityManagerImpl.java c410109
server/src/com/cloud/capacity/dao/CapacityDao.java 0c0723b
server/src/com/cloud/capacity/dao/CapacityDaoImpl.java a2df475
server/src/com/cloud/deploy/BareMetalPlanner.java 7616a38
server/src/com/cloud/deploy/FirstFitPlanner.java 06e46fb
server/src/com/cloud/hypervisor/HypervisorGuruBase.java 2efe6d3
server/src/com/cloud/resource/ResourceManagerImpl.java f82424a
server/src/com/cloud/vm/VirtualMachineManagerImpl.java e0647bb
server/src/com/cloud/vm/VirtualMachineProfileImpl.java e83d6a0
Diff: https://reviews.apache.org/r/9156/diff/
Testing (updated)
-------
Did manual testing.
Thanks,
bharat kumar
Re: Review Request: Cloudstack-711 Cpu and ram overcommit at cluster level.
Posted by bharat kumar <bh...@citrix.com>.
> On Jan. 30, 2013, 4:48 p.m., Rohit Yadav wrote:
> > Why not use Float instead of String param field type in Cmd class for both ratio variables?
> >
> > Don't use wildcards, import com.cloud.dc.*; (in ApiDBUtils)
> >
> > Fix code wherever ratio fields are used, no checks if they are 0.0f, fix code like: (long) ((svo.getRamSize() * 1024L * 1024L)/ramOvercommitRatio); for possible division error
> >
> > Fix field name typo to ratio.
> >
> > How to test it?
> >
> >
I am checking if the ram and cpu overcommit ratios are greater than one in addcluster api. So there will be no possibility of divide by zero error.
- bharat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9156/#review15865
-----------------------------------------------------------
On Jan. 30, 2013, 3:05 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9156/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2013, 3:05 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Prachi Damle, and Nitin Mehta.
>
>
> Description
> -------
>
> This patch enables cpu and ram overcommit on a per cluster basis(only for xenserver.).
> The dashboard will show actual values instead of the overcommit values.
>
>
> This addresses bug CLOUDSTACK-711.
>
>
> Diffs
> -----
>
> api/src/com/cloud/vm/VirtualMachineProfile.java 0fab443
> api/src/org/apache/cloudstack/api/ApiConstants.java 58a7831
> api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c64883c
> api/src/org/apache/cloudstack/api/response/ClusterResponse.java e436c99
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 065d3be
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 58b8a03
> server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java 2a5258c
> server/src/com/cloud/api/ApiDBUtils.java 0b08b26
> server/src/com/cloud/api/ApiResponseHelper.java 1c8849a
> server/src/com/cloud/capacity/CapacityManager.java fffb41f
> server/src/com/cloud/capacity/CapacityManagerImpl.java c410109
> server/src/com/cloud/capacity/dao/CapacityDao.java 0c0723b
> server/src/com/cloud/capacity/dao/CapacityDaoImpl.java a2df475
> server/src/com/cloud/deploy/BareMetalPlanner.java 7616a38
> server/src/com/cloud/deploy/FirstFitPlanner.java 06e46fb
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java 2efe6d3
> server/src/com/cloud/resource/ResourceManagerImpl.java f82424a
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java e0647bb
> server/src/com/cloud/vm/VirtualMachineProfileImpl.java e83d6a0
>
> Diff: https://reviews.apache.org/r/9156/diff/
>
>
> Testing
> -------
>
> Did manual testing.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-711 Cpu and ram overcommit at cluster level.
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9156/#review15865
-----------------------------------------------------------
Why not use Float instead of String param field type in Cmd class for both ratio variables?
Don't use wildcards, import com.cloud.dc.*; (in ApiDBUtils)
Fix code wherever ratio fields are used, no checks if they are 0.0f, fix code like: (long) ((svo.getRamSize() * 1024L * 1024L)/ramOvercommitRatio); for possible division error
Fix field name typo to ratio.
How to test it?
- Rohit Yadav
On Jan. 30, 2013, 3:05 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9156/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2013, 3:05 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Prachi Damle, and Nitin Mehta.
>
>
> Description
> -------
>
> This patch enables cpu and ram overcommit on a per cluster basis(only for xenserver.).
> The dashboard will show actual values instead of the overcommit values.
>
>
> This addresses bug CLOUDSTACK-711.
>
>
> Diffs
> -----
>
> api/src/com/cloud/vm/VirtualMachineProfile.java 0fab443
> api/src/org/apache/cloudstack/api/ApiConstants.java 58a7831
> api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c64883c
> api/src/org/apache/cloudstack/api/response/ClusterResponse.java e436c99
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 065d3be
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 58b8a03
> server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java 2a5258c
> server/src/com/cloud/api/ApiDBUtils.java 0b08b26
> server/src/com/cloud/api/ApiResponseHelper.java 1c8849a
> server/src/com/cloud/capacity/CapacityManager.java fffb41f
> server/src/com/cloud/capacity/CapacityManagerImpl.java c410109
> server/src/com/cloud/capacity/dao/CapacityDao.java 0c0723b
> server/src/com/cloud/capacity/dao/CapacityDaoImpl.java a2df475
> server/src/com/cloud/deploy/BareMetalPlanner.java 7616a38
> server/src/com/cloud/deploy/FirstFitPlanner.java 06e46fb
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java 2efe6d3
> server/src/com/cloud/resource/ResourceManagerImpl.java f82424a
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java e0647bb
> server/src/com/cloud/vm/VirtualMachineProfileImpl.java e83d6a0
>
> Diff: https://reviews.apache.org/r/9156/diff/
>
>
> Testing
> -------
>
> Did manual testing.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-711 Cpu and ram overcommit at cluster level.
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9156/#review15988
-----------------------------------------------------------
server/src/com/cloud/capacity/CapacityManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34286>
Can you add english comments as to what you doing here ?
server/src/com/cloud/capacity/CapacityManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34287>
keep this with actualTotalCpu
server/src/com/cloud/capacity/CapacityManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34291>
If we are going down this path for cpu and ram we should do the same for storage as well
server/src/com/cloud/capacity/CapacityManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34285>
lets not mix the terms overprovisioning and overcommit...lets be consistent...we have been using overprovisioning so please stick to it
server/src/com/cloud/capacity/CapacityManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34288>
with this logic change you will need to recreate these values for existing entries in op host capacity
server/src/com/cloud/capacity/CapacityManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34289>
expensive
server/src/com/cloud/capacity/CapacityManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34290>
make sure that the logging is consistent...please...you would want to show the over provisioned cpu and ram.
server/src/com/cloud/resource/ResourceManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34292>
What does this mean ? Is this logic broken for other hypervisors ?
- Nitin Mehta
On Jan. 30, 2013, 3:05 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9156/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2013, 3:05 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Prachi Damle, and Nitin Mehta.
>
>
> Description
> -------
>
> This patch enables cpu and ram overcommit on a per cluster basis(only for xenserver.).
> The dashboard will show actual values instead of the overcommit values.
>
>
> This addresses bug CLOUDSTACK-711.
>
>
> Diffs
> -----
>
> api/src/com/cloud/vm/VirtualMachineProfile.java 0fab443
> api/src/org/apache/cloudstack/api/ApiConstants.java 58a7831
> api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c64883c
> api/src/org/apache/cloudstack/api/response/ClusterResponse.java e436c99
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 065d3be
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 58b8a03
> server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java 2a5258c
> server/src/com/cloud/api/ApiDBUtils.java 0b08b26
> server/src/com/cloud/api/ApiResponseHelper.java 1c8849a
> server/src/com/cloud/capacity/CapacityManager.java fffb41f
> server/src/com/cloud/capacity/CapacityManagerImpl.java c410109
> server/src/com/cloud/capacity/dao/CapacityDao.java 0c0723b
> server/src/com/cloud/capacity/dao/CapacityDaoImpl.java a2df475
> server/src/com/cloud/deploy/BareMetalPlanner.java 7616a38
> server/src/com/cloud/deploy/FirstFitPlanner.java 06e46fb
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java 2efe6d3
> server/src/com/cloud/resource/ResourceManagerImpl.java f82424a
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java e0647bb
> server/src/com/cloud/vm/VirtualMachineProfileImpl.java e83d6a0
>
> Diff: https://reviews.apache.org/r/9156/diff/
>
>
> Testing
> -------
>
> Did manual testing.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-711 Cpu and ram overcommit at
cluster level.
Posted by Bharat Kumar <bh...@citrix.com>.
Nitin thanks for the review comments. will create a branch and fix the issues.
Bharat.
On Jan 30, 2013, at 8:35 PM, bharat kumar <bh...@citrix.com>> wrote:
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9156/
Review request for cloudstack, Abhinandan Prateek, Prachi Damle, and Nitin Mehta.
By bharat kumar.
Summary (updated)
Cloudstack-711 Cpu and ram overcommit at cluster level.
Description (updated)
This patch enables cpu and ram overcommit on a per cluster basis(only for xenserver.).
The dashboard will show actual values instead of the overcommit values.
Testing (updated)
Did manual testing.
Bugs: CLOUDSTACK-711
Diffs (updated)
* api/src/com/cloud/vm/VirtualMachineProfile.java (0fab443)
* api/src/org/apache/cloudstack/api/ApiConstants.java (58a7831)
* api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java (c64883c)
* api/src/org/apache/cloudstack/api/response/ClusterResponse.java (e436c99)
* plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java (065d3be)
* plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java (0ce91bc)
* plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java (58b8a03)
* server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java (2a5258c)
* server/src/com/cloud/api/ApiDBUtils.java (0b08b26)
* server/src/com/cloud/api/ApiResponseHelper.java (1c8849a)
* server/src/com/cloud/capacity/CapacityManager.java (fffb41f)
* server/src/com/cloud/capacity/CapacityManagerImpl.java (c410109)
* server/src/com/cloud/capacity/dao/CapacityDao.java (0c0723b)
* server/src/com/cloud/capacity/dao/CapacityDaoImpl.java (a2df475)
* server/src/com/cloud/deploy/BareMetalPlanner.java (7616a38)
* server/src/com/cloud/deploy/FirstFitPlanner.java (06e46fb)
* server/src/com/cloud/hypervisor/HypervisorGuruBase.java (2efe6d3)
* server/src/com/cloud/resource/ResourceManagerImpl.java (f82424a)
* server/src/com/cloud/vm/VirtualMachineManagerImpl.java (e0647bb)
* server/src/com/cloud/vm/VirtualMachineProfileImpl.java (e83d6a0)
View Diff<https://reviews.apache.org/r/9156/diff/>
Re: Review Request: Cloudstack-711 Cpu and ram overcommit at cluster level.
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9156/#review15926
-----------------------------------------------------------
Overall....good work.
The code volume is too high for me to understand all the changes at first glance.
I would suggest creating a branch as well so that you do not loose the changes and make progressive changes
api/src/com/cloud/vm/VirtualMachineProfile.java
<https://reviews.apache.org/r/9156/#comment34217>
You forgot to make changes for the upgrade
api/src/com/cloud/vm/VirtualMachineProfile.java
<https://reviews.apache.org/r/9156/#comment34218>
You need to change the alert manager as well
api/src/org/apache/cloudstack/api/ApiConstants.java
<https://reviews.apache.org/r/9156/#comment34209>
lets call it memory than RAM because thats the usage everywhere
api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java
<https://reviews.apache.org/r/9156/#comment34210>
Why String and not float ?
api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java
<https://reviews.apache.org/r/9156/#comment34211>
Can you put this validations with all the other ones ?
api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java
<https://reviews.apache.org/r/9156/#comment34212>
If its over commit then it should be >=1 ?
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
<https://reviews.apache.org/r/9156/#comment34215>
Should it be changing the following values
vm.setMemoryStaticMin(conn, memsize);
vm.setMemoryDynamicMin(conn, memsize);
vm.setMemoryDynamicMax(conn, memsize);
vm.setMemoryStaticMax(conn, memsize);
server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java
<https://reviews.apache.org/r/9156/#comment34213>
Doing this for every cluster means a lot of DB queries...can we cache it ? or store it cluster table itself ?
server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java
<https://reviews.apache.org/r/9156/#comment34216>
check tabs
check it across the board
server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java
<https://reviews.apache.org/r/9156/#comment34214>
please maintain spacing b/n commas
server/src/com/cloud/capacity/CapacityManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34219>
this makes the capacity check extremely expensive. Try keeping the ratio cached somewhr
server/src/com/cloud/capacity/CapacityManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34220>
add ram over commit ratio as well
server/src/com/cloud/vm/VirtualMachineManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34221>
expensive
- Nitin Mehta
On Jan. 30, 2013, 3:05 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9156/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2013, 3:05 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Prachi Damle, and Nitin Mehta.
>
>
> Description
> -------
>
> This patch enables cpu and ram overcommit on a per cluster basis(only for xenserver.).
> The dashboard will show actual values instead of the overcommit values.
>
>
> This addresses bug CLOUDSTACK-711.
>
>
> Diffs
> -----
>
> api/src/com/cloud/vm/VirtualMachineProfile.java 0fab443
> api/src/org/apache/cloudstack/api/ApiConstants.java 58a7831
> api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c64883c
> api/src/org/apache/cloudstack/api/response/ClusterResponse.java e436c99
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 065d3be
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 58b8a03
> server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java 2a5258c
> server/src/com/cloud/api/ApiDBUtils.java 0b08b26
> server/src/com/cloud/api/ApiResponseHelper.java 1c8849a
> server/src/com/cloud/capacity/CapacityManager.java fffb41f
> server/src/com/cloud/capacity/CapacityManagerImpl.java c410109
> server/src/com/cloud/capacity/dao/CapacityDao.java 0c0723b
> server/src/com/cloud/capacity/dao/CapacityDaoImpl.java a2df475
> server/src/com/cloud/deploy/BareMetalPlanner.java 7616a38
> server/src/com/cloud/deploy/FirstFitPlanner.java 06e46fb
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java 2efe6d3
> server/src/com/cloud/resource/ResourceManagerImpl.java f82424a
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java e0647bb
> server/src/com/cloud/vm/VirtualMachineProfileImpl.java e83d6a0
>
> Diff: https://reviews.apache.org/r/9156/diff/
>
>
> Testing
> -------
>
> Did manual testing.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-711 Cpu and ram overcommit at cluster level.
Posted by Abhinandan Prateek <ap...@apache.org>.
> On Feb. 19, 2013, 8:06 a.m., Sateesh Chodapuneedi wrote:
> > vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java, line 543
> > <https://reviews.apache.org/r/9156/diff/4/?file=259569#file259569line543>
> >
> > Memory & CPU host add would be dependent on following cases.
> > 1) OS type
> > 2) Host License
> > If either or both of above doesn't support memory / CPU hot add that would result in vm reconfiguration failure. This would block VM deployment.
> > Need to handle this.
Since enabling and disabling DMC is outside cloudstack control we in some situation will not know that DMC has changed. We can though document this fact and have the admin ensure that his cluster should support DMC if he is going to use it.
We should also clarify this issue in an update to community and document the above as prerequisite in FS.
- Abhinandan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9156/#review16735
-----------------------------------------------------------
On Feb. 18, 2013, 4:10 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9156/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2013, 4:10 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Prachi Damle, and Nitin Mehta.
>
>
> Description
> -------
>
> This patch enables cpu and ram overcommit on a per cluster basis(only for xenserver.).
> The dashboard will show actual values instead of the overcommit values.
>
>
> This addresses bug CLOUDSTACK-711.
>
>
> Diffs
> -----
>
> api/src/com/cloud/agent/api/to/VirtualMachineTO.java 8f3f0eb
> api/src/com/cloud/vm/VirtualMachineProfile.java 0fab443
> api/src/org/apache/cloudstack/api/ApiConstants.java d29408e
> api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java 912c396
> api/src/org/apache/cloudstack/api/response/ClusterResponse.java 551e530
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 552afb1
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java acfd9cf
> plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java 60e1a61
> plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java 721e5f7
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 88e03f5
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 841a535
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java c7ff5c7
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 58b8a03
> server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java a25e401
> server/src/com/cloud/api/ApiDBUtils.java 83132c6
> server/src/com/cloud/api/ApiResponseHelper.java 8c97615
> server/src/com/cloud/capacity/CapacityManager.java fffb41f
> server/src/com/cloud/capacity/CapacityManagerImpl.java d7b7053
> server/src/com/cloud/capacity/ComputeCapacityListener.java 8ea695a
> server/src/com/cloud/capacity/dao/CapacityDao.java 0c0723b
> server/src/com/cloud/capacity/dao/CapacityDaoImpl.java baaf391
> server/src/com/cloud/deploy/BareMetalPlanner.java 829a466
> server/src/com/cloud/deploy/FirstFitPlanner.java 66a24ac
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java e158962
> server/src/com/cloud/resource/ResourceManagerImpl.java 82013d4
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1838ed2
> server/src/com/cloud/vm/VirtualMachineProfileImpl.java e83d6a0
> vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff8e2
>
> Diff: https://reviews.apache.org/r/9156/diff/
>
>
> Testing
> -------
>
> Did manual testing.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-711 Cpu and ram overcommit at cluster level.
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9156/#review16735
-----------------------------------------------------------
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
<https://reviews.apache.org/r/9156/#comment35476>
Need to cleanup tabs here.
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
<https://reviews.apache.org/r/9156/#comment35477>
Need tabs cleanup here.
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
<https://reviews.apache.org/r/9156/#comment35478>
Need tabs cleanup here.
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
<https://reviews.apache.org/r/9156/#comment35479>
Need tabs cleanup here.
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
<https://reviews.apache.org/r/9156/#comment35481>
Need tabs cleanup here.
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
<https://reviews.apache.org/r/9156/#comment35483>
how about this parameter value set in existing deployments?
server/src/com/cloud/capacity/dao/CapacityDaoImpl.java
<https://reviews.apache.org/r/9156/#comment35484>
Need tabs cleanup here.
server/src/com/cloud/capacity/dao/CapacityDaoImpl.java
<https://reviews.apache.org/r/9156/#comment35485>
Need tabs cleanup here.
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java
<https://reviews.apache.org/r/9156/#comment35486>
Memory & CPU host add would be dependent on following cases.
1) OS type
2) Host License
If either or both of above doesn't support memory / CPU hot add that would result in vm reconfiguration failure. This would block VM deployment.
Need to handle this.
- Sateesh Chodapuneedi
On Feb. 18, 2013, 4:10 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9156/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2013, 4:10 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Prachi Damle, and Nitin Mehta.
>
>
> Description
> -------
>
> This patch enables cpu and ram overcommit on a per cluster basis(only for xenserver.).
> The dashboard will show actual values instead of the overcommit values.
>
>
> This addresses bug CLOUDSTACK-711.
>
>
> Diffs
> -----
>
> api/src/com/cloud/agent/api/to/VirtualMachineTO.java 8f3f0eb
> api/src/com/cloud/vm/VirtualMachineProfile.java 0fab443
> api/src/org/apache/cloudstack/api/ApiConstants.java d29408e
> api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java 912c396
> api/src/org/apache/cloudstack/api/response/ClusterResponse.java 551e530
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 552afb1
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java acfd9cf
> plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java 60e1a61
> plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java 721e5f7
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 88e03f5
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 841a535
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java c7ff5c7
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 58b8a03
> server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java a25e401
> server/src/com/cloud/api/ApiDBUtils.java 83132c6
> server/src/com/cloud/api/ApiResponseHelper.java 8c97615
> server/src/com/cloud/capacity/CapacityManager.java fffb41f
> server/src/com/cloud/capacity/CapacityManagerImpl.java d7b7053
> server/src/com/cloud/capacity/ComputeCapacityListener.java 8ea695a
> server/src/com/cloud/capacity/dao/CapacityDao.java 0c0723b
> server/src/com/cloud/capacity/dao/CapacityDaoImpl.java baaf391
> server/src/com/cloud/deploy/BareMetalPlanner.java 829a466
> server/src/com/cloud/deploy/FirstFitPlanner.java 66a24ac
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java e158962
> server/src/com/cloud/resource/ResourceManagerImpl.java 82013d4
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1838ed2
> server/src/com/cloud/vm/VirtualMachineProfileImpl.java e83d6a0
> vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff8e2
>
> Diff: https://reviews.apache.org/r/9156/diff/
>
>
> Testing
> -------
>
> Did manual testing.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-711 Cpu and ram overcommit at cluster level.
Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9156/#review16738
-----------------------------------------------------------
Any unit tests or automated functional tests to go along with these changes?
- David Nalley
On Feb. 18, 2013, 4:10 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9156/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2013, 4:10 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Prachi Damle, and Nitin Mehta.
>
>
> Description
> -------
>
> This patch enables cpu and ram overcommit on a per cluster basis(only for xenserver.).
> The dashboard will show actual values instead of the overcommit values.
>
>
> This addresses bug CLOUDSTACK-711.
>
>
> Diffs
> -----
>
> api/src/com/cloud/agent/api/to/VirtualMachineTO.java 8f3f0eb
> api/src/com/cloud/vm/VirtualMachineProfile.java 0fab443
> api/src/org/apache/cloudstack/api/ApiConstants.java d29408e
> api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java 912c396
> api/src/org/apache/cloudstack/api/response/ClusterResponse.java 551e530
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 552afb1
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java acfd9cf
> plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java 60e1a61
> plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java 721e5f7
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 88e03f5
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 841a535
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java c7ff5c7
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 58b8a03
> server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java a25e401
> server/src/com/cloud/api/ApiDBUtils.java 83132c6
> server/src/com/cloud/api/ApiResponseHelper.java 8c97615
> server/src/com/cloud/capacity/CapacityManager.java fffb41f
> server/src/com/cloud/capacity/CapacityManagerImpl.java d7b7053
> server/src/com/cloud/capacity/ComputeCapacityListener.java 8ea695a
> server/src/com/cloud/capacity/dao/CapacityDao.java 0c0723b
> server/src/com/cloud/capacity/dao/CapacityDaoImpl.java baaf391
> server/src/com/cloud/deploy/BareMetalPlanner.java 829a466
> server/src/com/cloud/deploy/FirstFitPlanner.java 66a24ac
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java e158962
> server/src/com/cloud/resource/ResourceManagerImpl.java 82013d4
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1838ed2
> server/src/com/cloud/vm/VirtualMachineProfileImpl.java e83d6a0
> vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff8e2
>
> Diff: https://reviews.apache.org/r/9156/diff/
>
>
> Testing
> -------
>
> Did manual testing.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-711 Cpu and ram overcommit at cluster level.
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9156/#review16934
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On Feb. 22, 2013, 11:34 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9156/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2013, 11:34 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Prachi Damle, and Nitin Mehta.
>
>
> Description
> -------
>
> This patch enables cpu and ram overcommit on a per cluster basis(only for xenserver.).
> The dashboard will show actual values instead of the overcommit values.
>
>
> This addresses bug CLOUDSTACK-711.
>
>
> Diffs
> -----
>
> api/src/com/cloud/agent/api/to/VirtualMachineTO.java 8f3f0eb
> api/src/com/cloud/resource/ResourceService.java 1e77cc8
> api/src/com/cloud/vm/VirtualMachineProfile.java 0fab443
> api/src/org/apache/cloudstack/api/ApiConstants.java b12e4cd
> api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java 912c396
> api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java 058c7eb
> api/src/org/apache/cloudstack/api/response/ClusterResponse.java 551e530
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BareMetalPlanner.java fe51eb0
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 9472ea2
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java acfd9cf
> plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java 40a5b98
> plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java 721e5f7
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 70f98cc
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 5cac253
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 33ad18d
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 58b8a03
> server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java a25e401
> server/src/com/cloud/api/ApiDBUtils.java c28daef
> server/src/com/cloud/api/ApiResponseHelper.java 41cf96e
> server/src/com/cloud/capacity/CapacityManager.java 656e744
> server/src/com/cloud/capacity/CapacityManagerImpl.java 74152ff
> server/src/com/cloud/capacity/ComputeCapacityListener.java 8ea695a
> server/src/com/cloud/capacity/dao/CapacityDao.java 0c0723b
> server/src/com/cloud/capacity/dao/CapacityDaoImpl.java 3582614
> server/src/com/cloud/deploy/FirstFitPlanner.java b452da0
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java e158962
> server/src/com/cloud/resource/ResourceManagerImpl.java 98044fb
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java 2b70ff6
> server/src/com/cloud/vm/VirtualMachineProfileImpl.java eb9e5ad
> server/test/com/cloud/capacity/CapacityManagerTest.java PRE-CREATION
> server/test/com/cloud/resource/MockResourceManagerImpl.java 889318b
> vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff8e2
>
> Diff: https://reviews.apache.org/r/9156/diff/
>
>
> Testing
> -------
>
> Did manual testing.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-711 Cpu and ram overcommit at cluster level.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9156/
-----------------------------------------------------------
(Updated Feb. 22, 2013, 11:34 a.m.)
Review request for cloudstack, Abhinandan Prateek, Prachi Damle, and Nitin Mehta.
Changes
-------
Fixed the changes in file ApiConstants.
Description
-------
This patch enables cpu and ram overcommit on a per cluster basis(only for xenserver.).
The dashboard will show actual values instead of the overcommit values.
This addresses bug CLOUDSTACK-711.
Diffs (updated)
-----
api/src/com/cloud/agent/api/to/VirtualMachineTO.java 8f3f0eb
api/src/com/cloud/resource/ResourceService.java 1e77cc8
api/src/com/cloud/vm/VirtualMachineProfile.java 0fab443
api/src/org/apache/cloudstack/api/ApiConstants.java b12e4cd
api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java 912c396
api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java 058c7eb
api/src/org/apache/cloudstack/api/response/ClusterResponse.java 551e530
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BareMetalPlanner.java fe51eb0
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 9472ea2
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java acfd9cf
plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java 40a5b98
plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java 721e5f7
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 70f98cc
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 5cac253
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 33ad18d
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 58b8a03
server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java a25e401
server/src/com/cloud/api/ApiDBUtils.java c28daef
server/src/com/cloud/api/ApiResponseHelper.java 41cf96e
server/src/com/cloud/capacity/CapacityManager.java 656e744
server/src/com/cloud/capacity/CapacityManagerImpl.java 74152ff
server/src/com/cloud/capacity/ComputeCapacityListener.java 8ea695a
server/src/com/cloud/capacity/dao/CapacityDao.java 0c0723b
server/src/com/cloud/capacity/dao/CapacityDaoImpl.java 3582614
server/src/com/cloud/deploy/FirstFitPlanner.java b452da0
server/src/com/cloud/hypervisor/HypervisorGuruBase.java e158962
server/src/com/cloud/resource/ResourceManagerImpl.java 98044fb
server/src/com/cloud/vm/VirtualMachineManagerImpl.java 2b70ff6
server/src/com/cloud/vm/VirtualMachineProfileImpl.java eb9e5ad
server/test/com/cloud/capacity/CapacityManagerTest.java PRE-CREATION
server/test/com/cloud/resource/MockResourceManagerImpl.java 889318b
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff8e2
Diff: https://reviews.apache.org/r/9156/diff/
Testing
-------
Did manual testing.
Thanks,
bharat kumar
Re: Review Request: Cloudstack-711 Cpu and ram overcommit at cluster level.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9156/
-----------------------------------------------------------
(Updated Feb. 21, 2013, 4:56 p.m.)
Review request for cloudstack, Abhinandan Prateek, Prachi Damle, and Nitin Mehta.
Changes
-------
Added a Test and made some changes to update cluster command to enable overcommit update.
Removed tabs.
Description
-------
This patch enables cpu and ram overcommit on a per cluster basis(only for xenserver.).
The dashboard will show actual values instead of the overcommit values.
This addresses bug CLOUDSTACK-711.
Diffs (updated)
-----
api/src/com/cloud/agent/api/to/VirtualMachineTO.java 8f3f0eb
api/src/com/cloud/resource/ResourceService.java 1e77cc8
api/src/com/cloud/vm/VirtualMachineProfile.java 0fab443
api/src/org/apache/cloudstack/api/ApiConstants.java cd7d700
api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java 912c396
api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java 058c7eb
api/src/org/apache/cloudstack/api/response/ClusterResponse.java 551e530
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 9472ea2
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java acfd9cf
plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java 40a5b98
plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java 721e5f7
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java e6d5742
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 5cac253
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 33ad18d
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 58b8a03
server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java a25e401
server/src/com/cloud/api/ApiDBUtils.java e6b1bf1
server/src/com/cloud/api/ApiResponseHelper.java a94e935
server/src/com/cloud/capacity/CapacityManager.java fffb41f
server/src/com/cloud/capacity/CapacityManagerImpl.java 4787c7b
server/src/com/cloud/capacity/ComputeCapacityListener.java 8ea695a
server/src/com/cloud/capacity/dao/CapacityDao.java 0c0723b
server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c33bfaf
server/src/com/cloud/deploy/BareMetalPlanner.java 829a466
server/src/com/cloud/deploy/FirstFitPlanner.java 66a24ac
server/src/com/cloud/hypervisor/HypervisorGuruBase.java e158962
server/src/com/cloud/resource/ResourceManagerImpl.java 79ccdb3
server/src/com/cloud/vm/VirtualMachineManagerImpl.java d0a2305
server/src/com/cloud/vm/VirtualMachineProfileImpl.java e83d6a0
server/test/com/cloud/capacity/CapacityManagerTest.java PRE-CREATION
server/test/com/cloud/resource/MockResourceManagerImpl.java 889318b
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff8e2
Diff: https://reviews.apache.org/r/9156/diff/
Testing
-------
Did manual testing.
Thanks,
bharat kumar
Re: Review Request: Cloudstack-711 Cpu and ram overcommit at cluster level.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9156/
-----------------------------------------------------------
(Updated Feb. 18, 2013, 4:10 p.m.)
Review request for cloudstack, Abhinandan Prateek, Prachi Damle, and Nitin Mehta.
Changes
-------
Added support for both kvm and vamware.
Description
-------
This patch enables cpu and ram overcommit on a per cluster basis(only for xenserver.).
The dashboard will show actual values instead of the overcommit values.
This addresses bug CLOUDSTACK-711.
Diffs (updated)
-----
api/src/com/cloud/agent/api/to/VirtualMachineTO.java 8f3f0eb
api/src/com/cloud/vm/VirtualMachineProfile.java 0fab443
api/src/org/apache/cloudstack/api/ApiConstants.java d29408e
api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java 912c396
api/src/org/apache/cloudstack/api/response/ClusterResponse.java 551e530
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 552afb1
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java acfd9cf
plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java 60e1a61
plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java 721e5f7
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 88e03f5
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 841a535
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java c7ff5c7
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 58b8a03
server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java a25e401
server/src/com/cloud/api/ApiDBUtils.java 83132c6
server/src/com/cloud/api/ApiResponseHelper.java 8c97615
server/src/com/cloud/capacity/CapacityManager.java fffb41f
server/src/com/cloud/capacity/CapacityManagerImpl.java d7b7053
server/src/com/cloud/capacity/ComputeCapacityListener.java 8ea695a
server/src/com/cloud/capacity/dao/CapacityDao.java 0c0723b
server/src/com/cloud/capacity/dao/CapacityDaoImpl.java baaf391
server/src/com/cloud/deploy/BareMetalPlanner.java 829a466
server/src/com/cloud/deploy/FirstFitPlanner.java 66a24ac
server/src/com/cloud/hypervisor/HypervisorGuruBase.java e158962
server/src/com/cloud/resource/ResourceManagerImpl.java 82013d4
server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1838ed2
server/src/com/cloud/vm/VirtualMachineProfileImpl.java e83d6a0
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 47ff8e2
Diff: https://reviews.apache.org/r/9156/diff/
Testing
-------
Did manual testing.
Thanks,
bharat kumar
Re: Review Request: Cloudstack-711 Cpu and ram overcommit at cluster level.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9156/
-----------------------------------------------------------
(Updated Feb. 1, 2013, 11:11 a.m.)
Review request for cloudstack, Abhinandan Prateek, Prachi Damle, and Nitin Mehta.
Changes
-------
updated the diff with a test to check the CheckIfHostHasCapacity function in CapacityManager.
Description
-------
This patch enables cpu and ram overcommit on a per cluster basis(only for xenserver.).
The dashboard will show actual values instead of the overcommit values.
This addresses bug CLOUDSTACK-711.
Diffs (updated)
-----
api/src/com/cloud/vm/VirtualMachineProfile.java 0fab443
api/src/org/apache/cloudstack/api/ApiConstants.java 58a7831
api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c64883c
api/src/org/apache/cloudstack/api/response/ClusterResponse.java e436c99
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 065d3be
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 58b8a03
server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java 2a5258c
server/src/com/cloud/api/ApiDBUtils.java 0b08b26
server/src/com/cloud/api/ApiResponseHelper.java 1c8849a
server/src/com/cloud/capacity/CapacityManager.java fffb41f
server/src/com/cloud/capacity/CapacityManagerImpl.java c410109
server/src/com/cloud/capacity/dao/CapacityDao.java 0c0723b
server/src/com/cloud/capacity/dao/CapacityDaoImpl.java a2df475
server/src/com/cloud/deploy/BareMetalPlanner.java 7616a38
server/src/com/cloud/deploy/FirstFitPlanner.java 06e46fb
server/src/com/cloud/hypervisor/HypervisorGuruBase.java 2efe6d3
server/src/com/cloud/resource/ResourceManagerImpl.java f82424a
server/src/com/cloud/vm/VirtualMachineManagerImpl.java e0647bb
server/src/com/cloud/vm/VirtualMachineProfileImpl.java e83d6a0
server/test/com/cloud/capacity/CapacityManagerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/9156/diff/
Testing
-------
Did manual testing.
Thanks,
bharat kumar