You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2019/09/27 12:45:19 UTC
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request
#1905: Fix es_scan_reader_test in debug mode
kangkaisen commented on a change in pull request #1905: Fix es_scan_reader_test in debug mode
URL: https://github.com/apache/incubator-doris/pull/1905#discussion_r329053577
##########
File path: be/src/exec/es/es_scan_reader.cpp
##########
@@ -104,9 +104,6 @@ Status ESScanReader::get_next(bool* scan_eos, std::unique_ptr<ScrollParser>& scr
LOG(WARNING) << "request scroll search failure["
<< "http status" << status
<< ", response: " << (response.empty() ? "empty response" : response);
- if (status == 404) {
Review comment:
It's unreachable
```
if (status == 404) {
LOG(WARNING) << "request scroll search failure 404["
<< ", response: " << (response.empty() ? "empty response" : response);
return Status::InternalError("No search context found for " + _scroll_id);
}
if (status != 200) {
LOG(WARNING) << "request scroll search failure["
<< "http status" << status
<< ", response: " << (response.empty() ? "empty response" : response);
if (status == 404) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org