You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Evelina Dumitrescu <ev...@gmail.com> on 2014/12/07 02:40:22 UTC
Review Request 28788: Added comment for getIP function declaration
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28788/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Dominic Hamon.
Repository: mesos-git
Description
-------
Added comment for getIP function declaration
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 39f6cb035eb5f9ec5ac8a7defb91bd1448df2a6c
Diff: https://reviews.apache.org/r/28788/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 28788: Added comment for getIP function declaration
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28788/#review64179
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28788]
All tests passed.
- Mesos ReviewBot
On Dec. 7, 2014, 1:40 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28788/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2014, 1:40 a.m.)
>
>
> Review request for mesos, Ben Mahler and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added comment for getIP function declaration
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 39f6cb035eb5f9ec5ac8a7defb91bd1448df2a6c
>
> Diff: https://reviews.apache.org/r/28788/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28788: Added comment for getIP function declaration
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28788/#review64253
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Dec. 6, 2014, 8:46 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28788/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2014, 8:46 p.m.)
>
>
> Review request for mesos, Ben Mahler and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added comment for getIP function declaration
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 39f6cb035eb5f9ec5ac8a7defb91bd1448df2a6c
>
> Diff: https://reviews.apache.org/r/28788/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28788: Added comment for getIP function declaration
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28788/#review64181
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28788]
All tests passed.
- Mesos ReviewBot
On Dec. 7, 2014, 4:46 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28788/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2014, 4:46 a.m.)
>
>
> Review request for mesos, Ben Mahler and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added comment for getIP function declaration
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 39f6cb035eb5f9ec5ac8a7defb91bd1448df2a6c
>
> Diff: https://reviews.apache.org/r/28788/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28788: Added comment for getIP function declaration
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28788/
-----------------------------------------------------------
(Updated Dec. 7, 2014, 4:46 a.m.)
Review request for mesos, Ben Mahler and Dominic Hamon.
Repository: mesos-git
Description
-------
Added comment for getIP function declaration
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 39f6cb035eb5f9ec5ac8a7defb91bd1448df2a6c
Diff: https://reviews.apache.org/r/28788/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu