[jira] Updated: (THRIFT-276) Ruby libraries should have one class per file

["Michael Stockton (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Stockton updated THRIFT-276:
------------------------------------

    Attachment: thrift-276.patch

o concentrated require statements in thrift.rb.
o underscored framedTransport, serverTransport and protocolFactory variables and arguments.
o renamed binary_protocol_accelerated to accelerated_binary_protocol.
o added Transport suffix and created individual files for transport classes.o renamed SimpleMongrelHTTPServer to MongrelHTTPServer.
o renamed nonblockingserver.rb to nonblocking_server.rb.
o renamed spec files accordingly.

> Ruby libraries should have one class per file
> ---------------------------------------------
>
>                 Key: THRIFT-276
>                 URL: https://issues.apache.org/jira/browse/THRIFT-276
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Library (Ruby)
>            Reporter: Bryan Duxbury
>            Assignee: Michael Stockton
>            Priority: Trivial
>         Attachments: thrift-276.patch
>
>
> There's no reason for so many of our classes to be lumped into the same file. For instance, transport.rb contains 9 classes. They may be short, but organizationally, it's superior to have separate class files. Of course, some files may contain more than one class per file as appropriate - things like a protocol and its factory, for instance, are perfectly acceptable to group.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.