You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/11/10 22:12:01 UTC
Re: Review Request 27826: Future::failure should have a const ref
return.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27826/
-----------------------------------------------------------
(Updated Nov. 10, 2014, 1:12 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
cody's comments
Summary (updated)
-----------------
Future::failure should have a const ref return.
Bugs: MESOS-1694
https://issues.apache.org/jira/browse/MESOS-1694
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
Diff: https://reviews.apache.org/r/27826/diff/
Testing
-------
make check.
manual review of calling code.
Thanks,
Dominic Hamon
Re: Review Request 27826: Future::failure should have a const ref
return.
Posted by Cody Maloney <co...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27826/#review60684
-----------------------------------------------------------
Ship it!
Ship It!
- Cody Maloney
On Nov. 10, 2014, 9:12 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27826/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 9:12 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1694
> https://issues.apache.org/jira/browse/MESOS-1694
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
>
> Diff: https://reviews.apache.org/r/27826/diff/
>
>
> Testing
> -------
>
> make check.
> manual review of calling code.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 27826: Future::failure should have a const ref
return.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Nov. 10, 2014, 1:50 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/include/process/future.hpp, line 1186
> > <https://reviews.apache.org/r/27826/diff/2/?file=757271#file757271line1186>
> >
> > Can we avoid the need for this with a separate change to use ABORT when failure() is called on a non-failed future? Much like we do for try, result, option.
https://reviews.apache.org/r/27831/
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27826/#review60686
-----------------------------------------------------------
On Nov. 10, 2014, 1:12 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27826/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 1:12 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1694
> https://issues.apache.org/jira/browse/MESOS-1694
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
>
> Diff: https://reviews.apache.org/r/27826/diff/
>
>
> Testing
> -------
>
> make check.
> manual review of calling code.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 27826: Future::failure should have a const ref
return.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27826/#review60686
-----------------------------------------------------------
Sounds good, I think we should first get rid of the empty string case though.
3rdparty/libprocess/include/process/future.hpp
<https://reviews.apache.org/r/27826/#comment102064>
Can we avoid the need for this with a separate change to use ABORT when failure() is called on a non-failed future? Much like we do for try, result, option.
- Ben Mahler
On Nov. 10, 2014, 9:12 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27826/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 9:12 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1694
> https://issues.apache.org/jira/browse/MESOS-1694
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
>
> Diff: https://reviews.apache.org/r/27826/diff/
>
>
> Testing
> -------
>
> make check.
> manual review of calling code.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 27826: Future::failure should have a const ref
return.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27826/#review60717
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Nov. 11, 2014, 12:13 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27826/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2014, 12:13 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1694
> https://issues.apache.org/jira/browse/MESOS-1694
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp bc8b878c9d101d2a2d4ae69b0bc6ff72edfe1431
>
> Diff: https://reviews.apache.org/r/27826/diff/
>
>
> Testing
> -------
>
> make check.
> manual review of calling code.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 27826: Future::failure should have a const ref
return.
Posted by Cody Maloney <co...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27826/#review60718
-----------------------------------------------------------
Ship it!
Ship It!
- Cody Maloney
On Nov. 11, 2014, 12:13 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27826/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2014, 12:13 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1694
> https://issues.apache.org/jira/browse/MESOS-1694
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp bc8b878c9d101d2a2d4ae69b0bc6ff72edfe1431
>
> Diff: https://reviews.apache.org/r/27826/diff/
>
>
> Testing
> -------
>
> make check.
> manual review of calling code.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 27826: Future::failure should have a const ref
return.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27826/
-----------------------------------------------------------
(Updated Nov. 10, 2014, 4:13 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
simplified based on ABORT change
Bugs: MESOS-1694
https://issues.apache.org/jira/browse/MESOS-1694
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/include/process/future.hpp bc8b878c9d101d2a2d4ae69b0bc6ff72edfe1431
Diff: https://reviews.apache.org/r/27826/diff/
Testing
-------
make check.
manual review of calling code.
Thanks,
Dominic Hamon
Re: Review Request 27826: Future::failure should have a const ref
return.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27826/#review60679
-----------------------------------------------------------
Patch looks great!
Reviews applied: [27826]
All tests passed.
- Mesos ReviewBot
On Nov. 10, 2014, 9:12 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27826/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 9:12 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1694
> https://issues.apache.org/jira/browse/MESOS-1694
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
>
> Diff: https://reviews.apache.org/r/27826/diff/
>
>
> Testing
> -------
>
> make check.
> manual review of calling code.
>
>
> Thanks,
>
> Dominic Hamon
>
>