You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/14 03:13:20 UTC

[GitHub] [airflow] mik-laj opened a new pull request #14766: Drop support for SequentialExecutor in Helm Chart

mik-laj opened a new pull request #14766:
URL: https://github.com/apache/airflow/pull/14766


   Close: https://github.com/apache/airflow/issues/14649
   
   CC: @dimberman @tooptoop4 @XD-DENG @kaxil 
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #14766: Drop support for SequentialExecutor in Helm Chart

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #14766:
URL: https://github.com/apache/airflow/pull/14766#issuecomment-798894014


   @XD-DENG Ready for a second review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #14766: Drop support for SequentialExecutor in Helm Chart

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #14766:
URL: https://github.com/apache/airflow/pull/14766#discussion_r593887802



##########
File path: chart/templates/rbac/pod-launcher-rolebinding.yaml
##########
@@ -19,8 +19,7 @@
 ## Airflow Pod Launcher Role Binding
 #################################
 {{- if and .Values.rbacEnabled .Values.allowPodLaunching }}
-{{- $schedulerLaunchExecutors := list "LocalExecutor" "SequentialExecutor" "KubernetesExecutor" "CeleryKubernetesExecutor" }}
-{{- $workerLaunchExecutors := list "CeleryExecutor" "KubernetesExecutor" "CeleryKubernetesExecutor" }}
+{{- $podLaunchExecutors := list "LocalExecutor" "KubernetesExecutor" "CeleryKubernetesExecutor" }}

Review comment:
       Thanks. This is a mistake. I have fixed it and updated the documentation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj merged pull request #14766: Drop support for SequentialExecutor in Helm Chart

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #14766:
URL: https://github.com/apache/airflow/pull/14766


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #14766: Drop support for SequentialExecutor in Helm Chart

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14766:
URL: https://github.com/apache/airflow/pull/14766#issuecomment-798939172


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #14766: Drop support for SequentialExecutor in Helm Chart

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #14766:
URL: https://github.com/apache/airflow/pull/14766#discussion_r593885470



##########
File path: chart/templates/check-values.yaml
##########
@@ -21,7 +21,18 @@ The sole purpose of this yaml file is it to check the values file is consistent
 
 {{- /*
 ##############################
-   Redis related checks
+  Executors related checks
+#############################
+*/ -}}
+  {{- $supportedExecutors := list "LocalExecutor" "CeleryExecutor" "KubernetesExecutor" "CeleryKubernetesExecutor" }}
+
+  {{- if not (has .Values.executor $supportedExecutors) }}
+    {{ required "Unsupported executor. Supported values: LocalExecutor, CeleryExecutor, KubernetesExecutor, CeleryKubernetesExecutor." nil }}

Review comment:
       Oh The change in this file should be deleted because I was able to validate it with JSON Schema.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] XD-DENG commented on a change in pull request #14766: Drop support for SequentialExecutor in Helm Chart

Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #14766:
URL: https://github.com/apache/airflow/pull/14766#discussion_r593883854



##########
File path: chart/templates/check-values.yaml
##########
@@ -21,7 +21,18 @@ The sole purpose of this yaml file is it to check the values file is consistent
 
 {{- /*
 ##############################
-   Redis related checks
+  Executors related checks
+#############################
+*/ -}}
+  {{- $supportedExecutors := list "LocalExecutor" "CeleryExecutor" "KubernetesExecutor" "CeleryKubernetesExecutor" }}
+
+  {{- if not (has .Values.executor $supportedExecutors) }}
+    {{ required "Unsupported executor. Supported values: LocalExecutor, CeleryExecutor, KubernetesExecutor, CeleryKubernetesExecutor." nil }}

Review comment:
       Can we reuse the variable `supportedExecutors`? So that avoid hard-coding the same thing.

##########
File path: chart/templates/scheduler/scheduler-networkpolicy.yaml
##########
@@ -40,7 +40,7 @@ spec:
       release: {{ .Release.Name }}
   policyTypes:
   - Ingress
-{{- if (or (eq .Values.executor "LocalExecutor") (eq .Values.executor "SequentialExecutor")) }}
+{{- if (eq .Values.executor "LocalExecutor") }}

Review comment:
       ```suggestion
   {{- if eq .Values.executor "LocalExecutor" }}
   ```

##########
File path: docs/helm-chart/index.rst
##########
@@ -42,12 +42,29 @@ This chart will bootstrap an `Airflow <https://airflow.apache.org>`__
 deployment on a `Kubernetes <http://kubernetes.io>`__ cluster using the
 `Helm <https://helm.sh>`__ package manager.
 
-Prerequisites
--------------
+Requirements
+------------
 
 -  Kubernetes 1.14+ cluster
 -  Helm 2.11+ or Helm 3.0+
--  PV provisioner support in the underlying infrastructure
+-  PV provisioner support in the underlying infrastructure (optionally)
+
+Features
+--------
+
+* Supported executors: ``LocalExecutor``, ``CeleryExecutor``, ``CeleryKubernetesExecutor``, ``KubernetesExecutor``.
+* Supported Airflow version: ``1.10+``, ``2.0+``
+* Supported database backend: ``PostgresSQL``, ``MySQL``
+* Autoscaling for ``CeleryExecutor`` provided by KEDA
+* PostgresSQL and PGBouncer with a battle-tested configuration

Review comment:
       ```suggestion
   * PostgresSQL and PgBouncer with a battle-tested configuration
   ```
   nit

##########
File path: chart/templates/scheduler/scheduler-service.yaml
##########
@@ -18,7 +18,7 @@
 ################################
 ## Airflow Scheduler Service
 #################################
-{{- if (or (eq .Values.executor "LocalExecutor") (eq .Values.executor "SequentialExecutor")) }}
+{{- if (eq .Values.executor "LocalExecutor") }}

Review comment:
       ```suggestion
   {{- if eq .Values.executor "LocalExecutor" }}
   ```

##########
File path: chart/templates/rbac/pod-launcher-rolebinding.yaml
##########
@@ -19,8 +19,7 @@
 ## Airflow Pod Launcher Role Binding
 #################################
 {{- if and .Values.rbacEnabled .Values.allowPodLaunching }}
-{{- $schedulerLaunchExecutors := list "LocalExecutor" "SequentialExecutor" "KubernetesExecutor" "CeleryKubernetesExecutor" }}
-{{- $workerLaunchExecutors := list "CeleryExecutor" "KubernetesExecutor" "CeleryKubernetesExecutor" }}
+{{- $podLaunchExecutors := list "LocalExecutor" "KubernetesExecutor" "CeleryKubernetesExecutor" }}

Review comment:
       I may have missed or misunderstood something: may you please help clarify why `CeleryExecutor` is not in this list?

##########
File path: chart/README.md
##########
@@ -28,11 +28,27 @@
 This chart will bootstrap an [Airflow](https://airflow.apache.org) deployment on a [Kubernetes](http://kubernetes.io)
 cluster using the [Helm](https://helm.sh) package manager.
 
-## Prerequisites
+## Requirements
 
 - Kubernetes 1.14+ cluster
 - Helm 2.11+ or Helm 3.0+
-- PV provisioner support in the underlying infrastructure
+- PV provisioner support in the underlying infrastructure (optionally)
+
+## Features
+
+* Supported executors: ``LocalExecutor``, ``CeleryExecutor``, ``CeleryKubernetesExecutor``, ``KubernetesExecutor``.
+* Supported Airflow version: ``1.10+``, ``2.0+``
+* Supported database backend: ``PostgresSQL``, ``MySQL``
+* Autoscaling for ``CeleryExecutor`` provided by KEDA
+* PostgresSQL and PGBouncer with a battle-tested configuration

Review comment:
       ```suggestion
   * PostgresSQL and PgBouncer with a battle-tested configuration
   ```
   
   nit




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org