[jira] [Commented] (FLINK-8242) ClassCastException in OrcTableSource.toOrcPredicate

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336382#comment-16336382 ] 

ASF GitHub Bot commented on FLINK-8242:
---------------------------------------

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/5345

    [FLINK-8242] [table] Fix predicate push-down of OrcTableSource

    ## What is the purpose of the change
    
    * Fix `ClassClassException` in `OrcTableSource` caused by hard cast to `Serializable`
    * Fix translation of Calcite literals with `NlString`
    
    ## Brief change log
    
    * add check to `OrcTableSource` before casting to `Serializable`
    * add logging to `OrcTableSource` for predicate push-down
    * add fallback for Calcite literal translation for `NlString` literals
    
    ## Verifying this change
    
    * adds a test to `OrcTableSourceTest.testApplyPredicate()`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **n/a**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink orcPushDown

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5345.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5345
    
----
commit 796deed1fe6372ca2eafc1f3b08387b7f29d5841
Author: Fabian Hueske <fh...@...>
Date:   2017-12-12T21:38:51Z

    [FLINK-8242] [orc] Fix predicate translation if literal is not Serializable.

commit 07b8fe1eaf68e175c963048980809a4ce4605643
Author: Fabian Hueske <fh...@...>
Date:   2018-01-23T21:10:00Z

    [FLINK-8242] [table] RexProgramExtractor convert NlsString literal always into String.

----


> ClassCastException in OrcTableSource.toOrcPredicate
> ---------------------------------------------------
>
>                 Key: FLINK-8242
>                 URL: https://issues.apache.org/jira/browse/FLINK-8242
>             Project: Flink
>          Issue Type: Bug
>          Components: Batch Connectors and Input/Output Formats
>    Affects Versions: 1.4.0
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>            Priority: Critical
>             Fix For: 1.5.0, 1.4.1
>
>
> The {{OrcTableSource}} tries to cast all predicate literals to {{Serializable}} in its {{toOrcPredicate()}} method. This fails with a {{ClassCastException}} if a literal is not serializable.
> Instead of failing, we should ignore the predicate and log a WARN message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)