You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "doublep (via GitHub)" <gi...@apache.org> on 2023/02/08 12:04:43 UTC
[GitHub] [commons-fileupload] doublep opened a new pull request, #200: FILEUPLOAD-348 - Add tests (already pass in 2.0).
doublep opened a new pull request, #200:
URL: https://github.com/apache/commons-fileupload/pull/200
This commit adds tests for https://issues.apache.org/jira/browse/FILEUPLOAD-348
The tests already pass in master. The point is to avoid this functionality becoming broken again in future, as in 1.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] jochenw merged pull request #200: FILEUPLOAD-348 - Add tests (already pass in 2.0).
Posted by "jochenw (via GitHub)" <gi...@apache.org>.
jochenw merged PR #200:
URL: https://github.com/apache/commons-fileupload/pull/200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] codecov-commenter commented on pull request #200: FILEUPLOAD-348 - Add tests (already pass in 2.0).
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #200:
URL: https://github.com/apache/commons-fileupload/pull/200#issuecomment-1423347567
# [Codecov](https://codecov.io/gh/apache/commons-fileupload/pull/200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#200](https://codecov.io/gh/apache/commons-fileupload/pull/200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ef1f1d1) into [master](https://codecov.io/gh/apache/commons-fileupload/commit/04f20fcf60672da409ade60a1bf38ea83e7b2427?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04f20fc) will **increase** coverage by `0.65%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #200 +/- ##
============================================
+ Coverage 71.08% 71.74% +0.65%
- Complexity 287 290 +3
============================================
Files 34 34
Lines 1214 1214
Branches 174 174
============================================
+ Hits 863 871 +8
+ Misses 281 271 -10
- Partials 70 72 +2
```
| [Impacted Files](https://codecov.io/gh/apache/commons-fileupload/pull/200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/commons/fileupload2/disk/DiskFileItem.java](https://codecov.io/gh/apache/commons-fileupload/pull/200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvZmlsZXVwbG9hZDIvZGlzay9EaXNrRmlsZUl0ZW0uamF2YQ==) | `63.63% <0.00%> (+7.27%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org