[GitHub] [hadoop] mukund-thakur edited a comment on pull request #3499: HADOOP-11867. Add a high performance vectored read API to file system.

[GitBox <gi...@apache.org>]

mukund-thakur edited a comment on pull request #3499:
URL: https://github.com/apache/hadoop/pull/3499#issuecomment-1016252274


   > Did an initial Review, looks really good. I think we should add an integration test around the ordered disjoint list of ranges as well to showcase them not merging and reading or having a few ranges where some are merged and some aren't by validating them. 
   
   Yeah already in my TODO. Thanks.
   
   > Also, are both minSeek and maxReadSize going to be configurable? I assume they are hardcoded just so you can test them out..
   Yes I will be making them configurable in consecutive PR's
   
   Also Please refer to the new PR now. https://github.com/apache/hadoop/pull/3904


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org