[GitHub] dgrove-oss commented on a change in pull request #2689: first stage of support for dynamic invoker id assignment

[gi...@git.apache.org]

dgrove-oss commented on a change in pull request #2689: first stage of support for dynamic invoker id assignment
URL: https://github.com/apache/incubator-openwhisk/pull/2689#discussion_r138134210
 
 

 ##########
 File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
 ##########
 @@ -87,6 +89,38 @@ object Invoker {
 
     val msgProvider = SpiLoader.get[MessagingProvider]
     val producer = msgProvider.getProducer(config, ec)
+
+    val invokerUUID = sys.env.getOrElse("INVOKER_ASSIGNED_UUID", UUID().toString)
+    val proposedInvokerId = if (args.length == 1) { args(0).toInt } else { -1 }
 
 Review comment:
   True with current simplistic code.  I could document/enforce that if we think it is important to do so.
   
   I think where we this is likely to end up is that the Registrar actor would get a little more complex and interact with the rest of the load balancing subsystem.  In particular, instead of blindly incrementing a counter if there is not match and no proposed id, it could first look to see if there is an abandoned topic (because of an unhealthy/offline invoker) and then prefer to assign that topic to the invoker instead of creating a new topic.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services