You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/03/01 19:48:50 UTC

[GitHub] reminisce commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet

reminisce commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet
URL: https://github.com/apache/incubator-mxnet/pull/9892#discussion_r171671603
 
 

 ##########
 File path: python/mxnet/contrib/serde/_import/__init__.py
 ##########
 @@ -0,0 +1,26 @@
+# coding: utf-8
+"""import function"""
+import onnx
+from .import_onnx import GraphProto
+
+def import_model(model_file):
 
 Review comment:
   Is `import_model` a user level API? If so, why is it registered under a hidden module `_import`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services