[GitHub] [beam] TheNeuralBit commented on a change in pull request #13871: [DO NOT MERGE][WIP] Final merge of website revamp

[GitBox <gi...@apache.org>]

TheNeuralBit commented on a change in pull request #13871:
URL: https://github.com/apache/beam/pull/13871#discussion_r568118611



##########
File path: website/www/site/i18n/home/calendar/en.yaml
##########
@@ -0,0 +1,44 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+ 
+# TODO:
+# Placeholder texts should be updated later

Review comment:
       We need to update the placeholders for this calendar. Or should they be generated?

##########
File path: website/www/site/data/en/quotes.yaml
##########
@@ -0,0 +1,23 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# TODO:
+# Placeholder texts should be updated later

Review comment:
       We need to update placeholder texts for these quotes.

##########
File path: website/www/site/layouts/index.html
##########
@@ -85,49 +70,108 @@
   </div>
 {{ end }}
 
-{{ define "logos-section" }}
-  <div class="logos section">
-    <div class="logos__title">
-      {{ T "home-logos-title" }}
-    </div>
-    <div class="logos__logos">
-      {{ range $logo := $.Site.Data.works_with }}
-      <div class="logos__logos__logo">
-        <a href="{{ $logo.url }}"><img src="{{ $logo.image_url }}" alt="{{ $logo.title }}"></a>
+{{/*
+  TODO:
+    This is the implementation of the design.
+    The event sync functionality will be implemented when we have the event page.

Review comment:
       We need to implement event page and event sync. @Jakub-Sadowski is there a PR for this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org