You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by GitBox <gi...@apache.org> on 2019/04/01 22:14:01 UTC

[GitHub] [bahir-flink] Wosin opened a new pull request #51: [BAHIR-177] Fixed state recovery for Flink and fixed size of the reco…

Wosin opened a new pull request #51: [BAHIR-177] Fixed state recovery for Flink and fixed size of the reco…
URL: https://github.com/apache/bahir-flink/pull/51
 
 
   Two issues are meant to be fixed in this PR:
   1) As described in BAHIR-177 currently the state recovery of Bahir operators depends on randomly generated IDs, which basically makes it impossible to recover state properly. The chagne has been done, so that the `outStreamId` is used instead of random names.
   2) The size of the queue recovered in `restoreQueuerState()` was equal to the actual size (number of elements) of the snapshot queue. If the queue was empty, the method would try to create queue with the size 0, which is currently forbidden for the `PriorityQueue` in Java.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services