You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/04/05 04:43:59 UTC
[GitHub] [dubbo-samples] kklinan opened a new pull request #158: Doc：update golang README.md
kklinan opened a new pull request #158: Doc：update golang README.md
URL: https://github.com/apache/dubbo-samples/pull/158
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kklinan commented on a change in pull request #158: Doc：update golang README.md
Posted by GitBox <gi...@apache.org>.
kklinan commented on a change in pull request #158: Doc：update golang README.md
URL: https://github.com/apache/dubbo-samples/pull/158#discussion_r403682744
##########
File path: golang/README.md
##########
@@ -66,7 +66,7 @@ go server
```bash
cd helloworld/dubbo/go-server
sh ./assembly/$ARCH/$ENV.sh
-cd ./target/linux/user_info_server-0.3.1-20190517-0930-release
+cd ./target/`go env GOOS`/user_info_server-<your version and date>-$ENV
Review comment:
Sorry, they have different definitions, see here:
- https://github.com/apache/dubbo-samples/blob/0f9cf247a29494deef086dc283843ec28550c836/golang/helloworld/dubbo/go-server/assembly/common/build.sh#L21
- https://github.com/apache/dubbo-samples/blob/0f9cf247a29494deef086dc283843ec28550c836/golang/helloworld/dubbo/go-server/assembly/mac/test.sh#L21
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] fangyincheng commented on a change in pull request #158: Doc：update golang README.md
Posted by GitBox <gi...@apache.org>.
fangyincheng commented on a change in pull request #158: Doc：update golang README.md
URL: https://github.com/apache/dubbo-samples/pull/158#discussion_r403680147
##########
File path: golang/README.md
##########
@@ -66,7 +66,7 @@ go server
```bash
cd helloworld/dubbo/go-server
sh ./assembly/$ARCH/$ENV.sh
-cd ./target/linux/user_info_server-0.3.1-20190517-0930-release
+cd ./target/`go env GOOS`/user_info_server-<your version and date>-$ENV
Review comment:
$ARCH right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org