[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #980: HDDS-3196 New PipelineManager interface to persist to RatisServer.

[GitBox <gi...@apache.org>]

timmylicheng commented on a change in pull request #980:
URL: https://github.com/apache/hadoop-ozone/pull/980#discussion_r433026298



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineStateManagerV2.java
##########
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * <p>http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * <p>Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.hadoop.hdds.scm.pipeline;
+
+import org.apache.hadoop.hdds.protocol.DatanodeDetails;
+import org.apache.hadoop.hdds.protocol.proto.HddsProtos;
+import org.apache.hadoop.hdds.scm.container.ContainerID;
+import org.apache.hadoop.hdds.scm.metadata.Replicate;
+
+import java.io.IOException;
+import java.util.Collection;
+import java.util.List;
+import java.util.NavigableSet;
+
+/**
+ * Manages the state of pipelines in SCM.
+ */
+public interface PipelineStateManagerV2 {
+
+  /**
+   * Adding pipeline would be replicated to Ratis.
+   * @param pipelineProto
+   * @throws IOException
+   */
+  @Replicate
+  void addPipeline(HddsProtos.Pipeline pipelineProto) throws IOException;
+
+  /**
+   * Removing pipeline would be replicated to Ratis.
+   * @param pipelineIDProto
+   * @return Pipeline removed
+   * @throws IOException
+   */
+  @Replicate
+  void removePipeline(HddsProtos.PipelineID pipelineIDProto)
+      throws IOException;
+
+  /**
+   * Updating pipeline state would be replicated to Ratis.
+   * @param pipelineIDProto
+   * @param newState
+   * @throws IOException
+   */
+  @Replicate
+  void updatePipelineState(HddsProtos.PipelineID pipelineIDProto,
+                           HddsProtos.PipelineState newState)
+      throws IOException;
+
+  void addContainerToPipeline(PipelineID pipelineID,
+                              ContainerID containerID) throws IOException;
+
+  Pipeline getPipeline(PipelineID pipelineID) throws PipelineNotFoundException;
+
+  List<Pipeline> getPipelines();
+
+  List<Pipeline> getPipelines(HddsProtos.ReplicationType type);
+
+  List<Pipeline> getPipelines(HddsProtos.ReplicationType type,
+                              HddsProtos.ReplicationFactor factor);
+
+  List<Pipeline> getPipelines(HddsProtos.ReplicationType type,
+                              HddsProtos.ReplicationFactor factor,
+                              Pipeline.PipelineState state);
+
+  List<Pipeline> getPipelines(HddsProtos.ReplicationType type,
+                              HddsProtos.ReplicationFactor factor,
+                              Pipeline.PipelineState state,
+                              Collection<DatanodeDetails> excludeDns,
+                              Collection<PipelineID> excludePipelines);
+
+  List<Pipeline> getPipelines(HddsProtos.ReplicationType type,
+                              Pipeline.PipelineState... states);
+
+  NavigableSet<ContainerID> getContainers(PipelineID pipelineID)
+      throws IOException;
+
+  int getNumberOfContainers(PipelineID pipelineID) throws IOException;
+
+
+  void removeContainerFromPipeline(PipelineID pipelineID,
+                                   ContainerID containerID) throws IOException;
+
+  void initialize() throws IOException;

Review comment:
       Updated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org