You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "krashouk (via GitHub)" <gi...@apache.org> on 2026/08/11 15:13:13 UTC

[PR] [ISSUE #1893] 使用 brokerId 生成 Dashboard 图表标签 [rocketmq-dashboard]

krashouk opened a new pull request, #1903:
URL: https://github.com/apache/rocketmq-dashboard/pull/1903

   ## 变更目的
   
   Broker Top 10 图表引用不存在的 broker.index，横轴标签显示 brokerName:undefined。
   
   ## 简要变更
   
   - 改用后端映射实际提供的 `brokerId`。
   - 提取图表数据生成函数，保持原有消息量排序和数值转换。
   - 覆盖主从 Broker 标签与排序回归。
   
   ## 本地验证
   
   - `DashboardPage.test.jsx`：1/1 通过（`CI=true npm test -- --runInBand`）
   - `git diff --check`：通过
   - 400 行范围门禁：通过
   
   ## 未执行
   
   未运行容器、RocketMQ 集群、完整 E2E、压力测试或镜像构建；这些重量级验证交由 PR 自动触发的上游检查。
   
   ## 提交清单
   
   - [x] 已创建唯一对应 Issue
   - [x] 一个 PR 只解决一个问题
   - [x] 已增加必要回归测试
   - [x] 已完成受影响范围的本地轻量验证
   
   Fixes #1893


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE #1893] 使用 brokerId 生成 Dashboard 图表标签 [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #1903: [ISSUE #1893] 使用 brokerId 生成 Dashboard 图表标签
URL: https://github.com/apache/rocketmq-dashboard/pull/1903


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE #1893] 使用 brokerId 生成 Dashboard 图表标签 [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #1903:
URL: https://github.com/apache/rocketmq-dashboard/pull/1903#issuecomment-5278420972

   Closing: this PR targets the legacy dashboard codebase (old src/ / frontend-new directories), which is no longer maintained. Development has moved to the new Studio architecture (server/ + web/), with the transition expected to complete in September. Thanks for the contribution — if the issue still applies to the new Studio, please feel free to open a new PR against the current structure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org