[jira] [Commented] (HADOOP-18820) AWS SDK v2: cut the v1 bridging support

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745652#comment-17745652 ] 

ASF GitHub Bot commented on HADOOP-18820:
-----------------------------------------

steveloughran opened a new pull request, #5872:
URL: https://github.com/apache/hadoop/pull/5872

   
   * downgrade v1 sdk to "provided"
   * only allowed in one package in production code
   * use isolated classes and reflection games to allow rest of module to work without it when instantiating credential providers.
   * tests updated as appropriate
   * remapping of standard aws v1 credential providers to v2 classnames prior to instantiation.
   
   
   
   ### How was this patch tested?
   
   Integration tests in progress
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   




> AWS SDK v2: cut the v1 bridging support
> ---------------------------------------
>
>                 Key: HADOOP-18820
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18820
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.4.0
>            Reporter: Steve Loughran
>            Priority: Major
>
> The AWS SDK v2 code includes the v1 sdk core for plugin support of
> * existing credential providers
> * delegation token binding
> I propose we break #2 and rely on those who have implemented to to upgrade. apart from all the needless changes the v2 SDK did to the api (why?) this is fairly straighforward
> for #1: fix through reflection, retaining a v1 sdk dependency at test time so we can verify that the binder works. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org