You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2019/05/17 02:24:12 UTC
Review Request 70660: Fix the XFS build for recent Fedora versions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70660/
-----------------------------------------------------------
Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.
Repository: mesos
Description
-------
On Fedora 30, we need to include <xfs/xfs.h> to get the right
types, since <xfs/xfs_types.h> is no longer self-contained. For
earlier versions, it is still safe to include both headers if
they are available, though <xfs/xfs_types.>h> may need to be
obtained via the xfsprogs-qa-devel package.
Diffs
-----
configure.ac b4bad5716986e2f7c132c6515179a65ccbfdaeac
src/slave/containerizer/mesos/isolators/xfs/utils.hpp db1829abbaac6113d39e71673403afe75b5ee738
Diff: https://reviews.apache.org/r/70660/diff/1/
Testing
-------
make check (Fedota 30)
make (CentOS 6)
Thanks,
James Peach
Re: Review Request 70660: Fix the XFS build for recent Fedora
versions.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70660/#review215327
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On May 16, 2019, 7:24 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70660/
> -----------------------------------------------------------
>
> (Updated May 16, 2019, 7:24 p.m.)
>
>
> Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On Fedora 30, we need to include <xfs/xfs.h> to get the right
> types, since <xfs/xfs_types.h> is no longer self-contained. For
> earlier versions, it is still safe to include both headers if
> they are available, though <xfs/xfs_types.>h> may need to be
> obtained via the xfsprogs-qa-devel package.
>
>
> Diffs
> -----
>
> configure.ac b4bad5716986e2f7c132c6515179a65ccbfdaeac
> src/slave/containerizer/mesos/isolators/xfs/utils.hpp db1829abbaac6113d39e71673403afe75b5ee738
>
>
> Diff: https://reviews.apache.org/r/70660/diff/1/
>
>
> Testing
> -------
>
> make check (Fedota 30)
> make (CentOS 6)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 70660: Fix the XFS build for recent Fedora
versions.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70660/#review215313
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70660]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 17, 2019, 2:24 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70660/
> -----------------------------------------------------------
>
> (Updated May 17, 2019, 2:24 a.m.)
>
>
> Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On Fedora 30, we need to include <xfs/xfs.h> to get the right
> types, since <xfs/xfs_types.h> is no longer self-contained. For
> earlier versions, it is still safe to include both headers if
> they are available, though <xfs/xfs_types.>h> may need to be
> obtained via the xfsprogs-qa-devel package.
>
>
> Diffs
> -----
>
> configure.ac b4bad5716986e2f7c132c6515179a65ccbfdaeac
> src/slave/containerizer/mesos/isolators/xfs/utils.hpp db1829abbaac6113d39e71673403afe75b5ee738
>
>
> Diff: https://reviews.apache.org/r/70660/diff/1/
>
>
> Testing
> -------
>
> make check (Fedota 30)
> make (CentOS 6)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 70660: Fix the XFS build for recent Fedora
versions.
Posted by Xudong Ni via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70660/#review215330
-----------------------------------------------------------
Ship it!
Ship It!
- Xudong Ni
On May 17, 2019, 2:24 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70660/
> -----------------------------------------------------------
>
> (Updated May 17, 2019, 2:24 a.m.)
>
>
> Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On Fedora 30, we need to include <xfs/xfs.h> to get the right
> types, since <xfs/xfs_types.h> is no longer self-contained. For
> earlier versions, it is still safe to include both headers if
> they are available, though <xfs/xfs_types.>h> may need to be
> obtained via the xfsprogs-qa-devel package.
>
>
> Diffs
> -----
>
> configure.ac b4bad5716986e2f7c132c6515179a65ccbfdaeac
> src/slave/containerizer/mesos/isolators/xfs/utils.hpp db1829abbaac6113d39e71673403afe75b5ee738
>
>
> Diff: https://reviews.apache.org/r/70660/diff/1/
>
>
> Testing
> -------
>
> make check (Fedota 30)
> make (CentOS 6)
>
>
> Thanks,
>
> James Peach
>
>